NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/52781: audioctl can't set output gain



On May 20,  6:59pm, nat%netbsd.org@localhost (Nathanial Sloss) wrote:
-- Subject: Re: kern/52781: audioctl can't set output gain

| 
| How about the attached patch it will set the hw gain also if their is only one 
| channel open (recording or playback).  If this is good I'll document this 
| behaviour and update the spec.
| 
| Best regards,
| 
| Nat

I would write this:

| +		if (sc->sc_opens == 1 || !sc->sc_usemixer ||
| +						 vc == &sc->sc_mixring) {

as a macro or inline function because we keep repeating it.

christos


Home | Main Index | Thread Index | Old Index