Re: kern/53217: -current: dumping to wedges on GPT disks broken

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR kern/53217; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/53217: -current: dumping to wedges on GPT disks broken
Date: Fri, 27 Apr 2018 15:15:38 +0200

 On Fri, Apr 27, 2018 at 01:05:01PM +0000, Frank Kardel wrote:
 >  As long as it works, fine.
 
 Everything else is pretty dangerous ;-)
 
 >  It violates, though, a bit the principle of least astonishment. 
 >  sometimes GPT disks would have a full disk partition with "swap" 
 >  sometime with "unused"
 
 I think there is confusion which disk devices "label" we are talking about
 here (and what the code checks).
 
 The full disk "partition" of the fictious (purely internal) label on my
 dk1 partition better be of type swap, while my dk0 better be ffs:
 
 wd0: GPT GUID: d96ce1d6-f47b-464b-b0c8-b8fea0d23f31
 dk0 at wd0: Guru-Root
 dk0: 5856338797 blocks at 34, type: ffs
 dk1 at wd0: d5c3eff7-a35d-41b3-9c58-76679533f5cb
 dk1: 4194304 blocks at 5856338831, type: swap
 wd0: drive supports PIO mode 4, DMA mode 2, Ultra-DMA mode 6 (Ultra/133)
 
 But wd0's internal label should have a raw partition of type unused.
 
 The latter is true, the former two I can't check easily as dk* does not
 provide access to the label (which is good too).
 
 
 Martin