Re: kern/53217: -current: dumping to wedges on GPT disks broken

[Frank Kardel <kardel%netbsd.org@localhost>]

The following reply was made to PR kern/53217; it has been noted by GNATS.

From: Frank Kardel <kardel%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/53217: -current: dumping to wedges on GPT disks broken
Date: Fri, 27 Apr 2018 15:01:25 +0200

 As long as it works, fine.
 
 It violates, though, a bit the principle of least astonishment. 
 sometimes GPT disks would have a full disk partition with "swap" 
 sometime with "unused" - both are not really describing the GPT label 
 situation. But this should not be a long discussion - getting dumps 
 again on EFI systems is more important.
 
 Frank
 
 
 On 04/27/18 09:45, Martin Husemann wrote:
 > The following reply was made to PR kern/53217; it has been noted by GNATS.
 >
 > From: Martin Husemann <martin%duskware.de@localhost>
 > To: gnats-bugs%NetBSD.org@localhost
 > Cc:
 > Subject: Re: kern/53217: -current: dumping to wedges on GPT disks broken
 > Date: Fri, 27 Apr 2018 09:42:05 +0200
 >
 >   On Thu, Apr 26, 2018 at 07:10:00PM +0000, kardel%netbsd.org@localhost wrote:
 >   > >Fix:
 >   > 	Maybe also accept FS_UNUSED as fstype?
 >   
 >   I'd rather have the dkwedge_gpt.c code set the partition type of the
 >   fake label for the whole disk of the wedge to FS_SWAP when dkw.dkw_ptype
 >   is DKW_PTYPE_SWAP.
 >   
 >   Martin
 >