PR/52682 CVS commit: [netbsd-8] src/sys/dist/pf/net

["Soren Jacobsen" <snj%netbsd.org@localhost>]

The following reply was made to PR kern/52682; it has been noted by GNATS.

From: "Soren Jacobsen" <snj%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/52682 CVS commit: [netbsd-8] src/sys/dist/pf/net
Date: Sat, 10 Feb 2018 04:12:17 +0000

 Module Name:	src
 Committed By:	snj
 Date:		Sat Feb 10 04:12:17 UTC 2018
 
 Modified Files:
 	src/sys/dist/pf/net [netbsd-8]: pf.c
 
 Log Message:
 Pull up following revision(s) (requested by maxv in ticket #540):
 	sys/dist/pf/net/pf.c: 1.77-1.78
 PR/52682: David Binderman: Fix wrong assignment (in the !__NetBSD__ code)
 Oh, what is this. Fix a remotely-triggerable integer overflow: the way we
 define TCPOLEN_SACK makes it unsigned, and the comparison in the while()
 is unsigned too. That's not the expected behavior, the original code
 wanted a signed comparison.
 It's pretty easy to make 'hlen' go negative and trigger a buffer overflow.
 This bug was reported 8 years ago by Lucio Albornoz in PR/44059.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.76 -r1.76.6.1 src/sys/dist/pf/net/pf.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.