[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: bin/51418: Fix incore src/sbin/fsck_lfs/bufcache.c
The following reply was made to PR bin/51418; it has been noted by GNATS.
From: Jose Luis Rodriguez Garcia <joseyluis%gmail.com@localhost>
Subject: Re: bin/51418: Fix incore src/sbin/fsck_lfs/bufcache.c
Date: Wed, 22 Nov 2017 12:39:29 +0100
I have tested this patch one more time and it seems fine. Please commit it.
I couldn't reproduce the previous failures, they must have been problems
with my old QEMU/FreeBSD setup that it isn't enough stable.
I have passed the fs tests, newfs, uncompress several tars and all has
been ok. (doing more operations with the filesystem fails after/before
the patch but these are other bugs of lfs).
This patch is needed because on 32 bits systems (daddr_t is a int64_t)
there will be corruption/slow performance for LFS fileystems > 1 Tbyte
(LFS2 allows up to 2 Tbytes according to the roadmap) and LFS64.
On Mon, Dec 5, 2016 at 3:10 PM, Jose Luis Rodriguez Garcia
> The following reply was made to PR bin/51418; it has been noted by GNATS.
> From: Jose Luis Rodriguez Garcia <joseyluis%gmail.com@localhost>
> To: gnats-bugs%netbsd.org@localhost
> Subject: Re: bin/51418: Fix incore src/sbin/fsck_lfs/bufcache.c
> Date: Mon, 5 Dec 2016 15:05:27 +0100
> Looking in other pieces of code, it seems that sometimes negative
> numbers are used. I did some tests time ago, and this patch broke
> The treatment of disk address seems inconsistent. In buffcache.c uses
> mainly daddr_t (unsigned) and in other parts of the code uses signed
> numbers. It seems confussing and prone to errors.
> On Wed, Aug 17, 2016 at 1:40 PM, <gnats-admin%netbsd.org@localhost> wrote:
> > Thank you very much for your problem report.
> > It has the internal identification `bin/51418'.
> > The individual assigned to look at your
> > report is: bin-bug-people.
> >>Category: bin
> >>Responsible: bin-bug-people
> >>Synopsis: Fix incore src/sbin/fsck_lfs/bufcache.c
> >>Arrival-Date: Wed Aug 17 11:40:00 +0000 2016
Main Index |
Thread Index |