Re: bin/51418: Fix incore src/sbin/fsck_lfs/bufcache.c

[Jose Luis Rodriguez Garcia <joseyluis%gmail.com@localhost>]

The following reply was made to PR bin/51418; it has been noted by GNATS.

From: Jose Luis Rodriguez Garcia <joseyluis%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: bin/51418: Fix incore src/sbin/fsck_lfs/bufcache.c
Date: Mon, 5 Dec 2016 15:05:27 +0100

 Looking in other pieces of code, it seems that sometimes negative
 numbers are used. I did some tests time ago, and this patch broke
 somethings.
 
 The treatment of disk address seems inconsistent. In buffcache.c uses
 mainly daddr_t (unsigned) and in other parts of the code uses signed
 numbers. It seems confussing and prone to errors.
 
 On Wed, Aug 17, 2016 at 1:40 PM,  <gnats-admin%netbsd.org@localhost> wrote:
 > Thank you very much for your problem report.
 > It has the internal identification `bin/51418'.
 > The individual assigned to look at your
 > report is: bin-bug-people.
 >
 >>Category:       bin
 >>Responsible:    bin-bug-people
 >>Synopsis:       Fix incore src/sbin/fsck_lfs/bufcache.c
 >>Arrival-Date:   Wed Aug 17 11:40:00 +0000 2016
 >