Re: PR/52522 CVS commit: src/sbin/gpt

[christos%zoulas.com@localhost (Christos Zoulas)]

On Sep 6,  4:54pm, aniou%smutek.pl@localhost (Piotr Meyer) wrote:
-- Subject: Re: PR/52522 CVS commit: src/sbin/gpt

| On Tue, Sep 05, 2017 at 06:35:01PM +0000, Christos Zoulas wrote:
| >  
| >  Modified Files:
| >  	src/sbin/gpt: gpt.c
| >  
| >  Log Message:
| >  PR/52522: Piotr Meyer: Don't NUL terminate the gpt label name.
| >  XXX: pullup-8
| >  
| >  
| >  To generate a diff of this commit:
| >  cvs rdiff -u -r1.70 -r1.71 src/sbin/gpt/gpt.c
| 
| I'm afraid that is too early to pullup - truncating long labels 
| by NUL is only small fraction of problem and without number of 
| other changes things are now worse: now, we are able to create 
| label with max-length (36 UTF-16 characters) but shorter labels,
| created by NetBSD are not valid - there is no "end mark" (NUL)
| (I assume that destination buffer isn't zeroed during allocation).
| 
| In the same time userland and kernel parts that assume
| that string IS NUL-terminated are still here, for example in gpt:
| https://nxr.netbsd.org/xref/src/sbin/gpt/gpt.c?r=1.71#132
| (but there may be other places as well).

You are right, fixed in userland.

christos