Re: bin/52512: Duplicate files prevent veriexecctl from loading signature file

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR bin/52512; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: bin/52512: Duplicate files prevent veriexecctl from loading
 signature file
Date: Wed, 30 Aug 2017 06:44:47 +0200

 On Tue, Aug 29, 2017 at 11:45:00PM +0000, Paul Goyette wrote:
 >  But this all seems moot to me, since the only info I have available for
 >  the original file entry is the veriexec_file_entry itself.
 >  
 >  /* Veriexec per-file entry data. */
 >  struct veriexec_file_entry {
 >           krwlock_t lock;                         /* r/w lock */
 >           u_char *filename;                       /* File name. */
 >           u_char type;                            /* Entry type. */
 >           u_char status;                          /* Evaluation status. */
 >           u_char *fp;                             /* Fingerprint. */
 >           struct veriexec_fpops *ops;             /* Fingerprint ops vector*/
 >           size_t filename_len;                    /* Length of filename. */
 >  };
 
 This would need to gain a void* / size_t for the original file handle,
 which would be optional (just like filename), and if present could be
 compared with memcpy() to the new entry.
 
 However, the attack surface for a collision at this level is probably empty,
 so lets keep it simple.
 
 Martin