Re: bin/52512: Duplicate files prevent veriexecctl from loading signature file

[Paul Goyette <paul%whooppee.com@localhost>]

The following reply was made to PR bin/52512; it has been noted by GNATS.

From: Paul Goyette <paul%whooppee.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: bin/52512: Duplicate files prevent veriexecctl from loading
 signature file
Date: Tue, 29 Aug 2017 18:38:45 +0800 (+08)

   This message is in MIME format.  The first part should be readable text,
   while the remaining parts are likely unreadable without MIME-aware tools.
 
 --0-1754746076-1504003125=:22778
 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
 
 >> It is unclear whether we should modify veriexecctl to not set the error for 
 >> EEXIST, or if we should modify veriexecgen to not generate multiple entries 
 >> (with different names) for the same file.  (It seems to me unreasonable to 
 >> expect the user to remove the duplicates.)
 >
 > A third option would be to modify the kernel code to not complain when 
 > attempting to add a new entry, as long as the new fingerprint type and value 
 > match the existing values.
 
 The attached patch implements this option.
 
 
 --0-1754746076-1504003125=:22778
 Content-Type: TEXT/PLAIN; charset=US-ASCII; name=kern_veriexec.c.diff
 Content-Transfer-Encoding: BASE64
 Content-ID: <Pine.NEB.4.64.1708291838450.22778%speedy.whooppee.com@localhost>
 Content-Description: 
 Content-Disposition: attachment; filename=kern_veriexec.c.diff
 
 SW5kZXg6IGtlcm5fdmVyaWV4ZWMuYw0KPT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PQ0KUkNTIGZpbGU6IC9jdnNyb290L3NyYy9zeXMva2Vybi9rZXJuX3Zlcmll
 eGVjLmMsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjE0DQpkaWZmIC11IC1w
 IC1yMS4xNCBrZXJuX3ZlcmlleGVjLmMNCi0tLSBrZXJuX3ZlcmlleGVjLmMJ
 MjkgQXVnIDIwMTcgMTA6MjM6MTIgLTAwMDAJMS4xNA0KKysrIGtlcm5fdmVy
 aWV4ZWMuYwkyOSBBdWcgMjAxNyAxMDozNzoxNyAtMDAwMA0KQEAgLTEwNTAs
 OSArMTA1MCwxMSBAQCB2ZXJpZXhlY19maWxlX2FkZChzdHJ1Y3QgbHdwICps
 LCBwcm9wX2RpDQogew0KIAlzdHJ1Y3QgdmVyaWV4ZWNfdGFibGVfZW50cnkg
 KnZ0ZTsNCiAJc3RydWN0IHZlcmlleGVjX2ZpbGVfZW50cnkgKnZmZSA9IE5V
 TEw7DQorCXN0cnVjdCB2ZXJpZXhlY19maWxlX2VudHJ5ICpvdmZlOw0KIAlz
 dHJ1Y3Qgdm5vZGUgKnZwOw0KIAljb25zdCBjaGFyICpmaWxlLCAqZnBfdHlw
 ZTsNCiAJaW50IGVycm9yOw0KKwlib29sIGlnbm9yZV9kdXAgPSBmYWxzZTsN
 CiANCiAJaWYgKCFwcm9wX2RpY3Rpb25hcnlfZ2V0X2NzdHJpbmdfbm9jb3B5
 KGRpY3QsICJmaWxlIiwgJmZpbGUpKQ0KIAkJcmV0dXJuIChFSU5WQUwpOw0K
 QEAgLTEwOTYsMTIgKzEwOTgsNiBAQCB2ZXJpZXhlY19maWxlX2FkZChzdHJ1
 Y3QgbHdwICpsLCBwcm9wX2RpDQogDQogCXJ3X2VudGVyKCZ2ZXJpZXhlY19v
 cF9sb2NrLCBSV19XUklURVIpOw0KIA0KLQlpZiAodmVyaWV4ZWNfZ2V0KHZw
 KSkgew0KLQkJLyogV2UgYWxyZWFkeSBoYXZlIGFuIGVudHJ5IGZvciB0aGlz
 IGZpbGUuICovDQotCQllcnJvciA9IEVFWElTVDsNCi0JCWdvdG8gdW5sb2Nr
 X291dDsNCi0JfQ0KLQ0KIAkvKiBDb250aW51ZSBlbnRyeSBpbml0aWFsaXph
 dGlvbi4gKi8NCiAJaWYgKHByb3BfZGljdGlvbmFyeV9nZXRfdWludDgoZGlj
 dCwgImVudHJ5LXR5cGUiLCAmdmZlLT50eXBlKSA9PSBGQUxTRSkNCiAJCXZm
 ZS0+dHlwZSA9IDA7DQpAQCAtMTE0MCw2ICsxMTM2LDIyIEBAIHZlcmlleGVj
 X2ZpbGVfYWRkKHN0cnVjdCBsd3AgKmwsIHByb3BfZGkNCiAJCXZmZS0+c3Rh
 dHVzID0gc3RhdHVzOw0KIAl9DQogDQorCS8qDQorCSAqIElmIHdlIGFscmVh
 ZHkgaGF2ZSBhbiBlbnRyeSBmb3IgdGhpcyBmaWxlLCBhbmQgaXQgbWF0Y2hl
 cw0KKwkgKiB0aGUgbmV3IGVudHJ5IGV4YWN0bHkgKGV4Y2VwdCBmb3IgdGhl
 IGZpbGVuYW1lLCBzaW5jZSBpdA0KKwkgKiBtaWdodCBiZSBoYXJkLWxpbmtl
 ZCEpLCB3ZSBqdXN0IGlnbm9yZSB0aGUgbmV3IGVudHJ5LiAgSWYNCisJICog
 dGhlIG5ldyBlbnRyeSBkaWZmZXJzLCByZXBvcnQgdGhlIGVycm9yLg0KKwkg
 Ki8NCisJaWYgKChvdmZlID0gdmVyaWV4ZWNfZ2V0KHZwKSkgIT0gTlVMTCkg
 ew0KKwkJZXJyb3IgPSBFRVhJU1Q7DQorCQlpZiAodmZlLT50eXBlID09IG92
 ZmUtPnR5cGUgJiYNCisJCSAgICB2ZmUtPnN0YXR1cyA9PSBvdmZlLT5zdGF0
 dXMgJiYNCisJCSAgICB2ZmUtPm9wcyA9PSBvdmZlLT5vcHMgJiYNCisJCSAg
 ICBtZW1jbXAodmZlLT5mcCwgb3ZmZS0+ZnAsIHZmcy0+b3BzLT5oYXNoX2xl
 bikgPT0gMCkNCisJCQlpZ25vcmVfZHVwID0gdHJ1ZTsNCisJCWdvdG8gdW5s
 b2NrX291dDsNCisJfQ0KKw0KIAl2dGUgPSB2ZXJpZXhlY190YWJsZV9sb29r
 dXAodnAtPnZfbW91bnQpOw0KIAlpZiAodnRlID09IE5VTEwpDQogCQl2dGUg
 PSB2ZXJpZXhlY190YWJsZV9hZGQobCwgdnAtPnZfbW91bnQpOw0KQEAgLTEx
 NzQsNiArMTE4Niw5IEBAIHZlcmlleGVjX2ZpbGVfYWRkKHN0cnVjdCBsd3Ag
 KmwsIHByb3BfZGkNCiAJaWYgKGVycm9yKQ0KIAkJdmVyaWV4ZWNfZmlsZV9m
 cmVlKHZmZSk7DQogDQorCWlmIChpZ25vcmVfZHVwICYmIGVycm9yID09IEVF
 WElTVCkNCisJCWVycm9yID0gMDsNCisNCiAJcmV0dXJuIChlcnJvcik7DQog
 fQ0KIA0K
 
 --0-1754746076-1504003125=:22778--