Re: kern/52462: aac driver (and possibly others) needs MPification

[Havard Eidnes <he%NetBSD.org@localhost>]

The following reply was made to PR kern/52462; it has been noted by GNATS.

From: Havard Eidnes <he%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost, mlelstv%serpens.de@localhost
Cc: kern-bug-people%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Subject: Re: kern/52462: aac driver (and possibly others) needs MPification
Date: Tue, 08 Aug 2017 14:58:16 +0200 (CEST)

 >  Ok. For the next try: remove the patch and simply declare ld as non-=
 mpsafe
 >  by removing the D_MPSAFE flags.
 
 OK, did that with
 
 vk# cvs diff sys/dev/ld.c
 Index: sys/dev/ld.c
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /cvsroot/src/sys/dev/ld.c,v
 retrieving revision 1.101
 diff -u -r1.101 ld.c
 --- sys/dev/ld.c        27 Apr 2017 17:07:22 -0000      1.101
 +++ sys/dev/ld.c        8 Aug 2017 12:56:06 -0000
 @@ -92,7 +92,7 @@
         .d_dump =3D lddump,
         .d_psize =3D ldsize,
         .d_discard =3D lddiscard,
 -       .d_flag =3D D_DISK | D_MPSAFE
 +       .d_flag =3D D_DISK
  };
  =
 
  const struct cdevsw ld_cdevsw =3D {
 @@ -107,7 +107,7 @@
         .d_mmap =3D nommap,
         .d_kqfilter =3D nokqfilter,
         .d_discard =3D lddiscard,
 -       .d_flag =3D D_DISK | D_MPSAFE
 +       .d_flag =3D D_DISK
  };
  =
 
  static struct  dkdriver lddkdriver =3D {
 vk#
 
 and now the machine behaves as it should, and no longer panics or
 wedges.
 
 Regards,
 
 - H=E5vard