NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: kern/52468: ISA DMA incorrectly maps I/O port 0x80 for page address registers



thanks for looking into this.

>  -static int dmapageport[2][4] = {
>  -	{0x7, 0x3, 0x1, 0x2},
>  -	{0xf, 0xb, 0x9, 0xa}
>  +static const int dmapageport[2][4] = {
>  +	{0x87, 0x83, 0x81, 0x82},
>  +	{0x8f, 0x8b, 0x89, 0x8a}
>   };
[ ... ]
>   		bus_space_write_1(ids->ids_bst, ids->ids_dmapgh,
>  -		    dmapageport[0][ochan], (dmaaddr >> 16) & 0xff);
>  +		    dmapageport[0][ochan] - IO_DMAPG, (dmaaddr >> 16) & 0xff);

i would rather see this where dmapageport[] values are simply
reduced by 1 and then bus_space accesses remain as-is.

thanks!


.mrg.


Home | Main Index | Thread Index | Old Index