Re: port-arm/52163 - support for gpio for Xscale

[Paul Goyette <paul%whooppee.com@localhost>]

The following reply was made to PR port-arm/52163; it has been noted by GNATS.

From: Paul Goyette <paul%whooppee.com@localhost>
To: smesgr <smesgr%gmail.com@localhost>
Cc: gnats-bugs%NetBSD.org@localhost, port-arm-maintainer%netbsd.org@localhost, 
    gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Subject: Re: port-arm/52163 - support for gpio for Xscale
Date: Wed, 17 May 2017 16:51:06 +0800 (+08)

 On Wed, 17 May 2017, Paul Goyette wrote:
 
 > On Tue, 16 May 2017, smesgr wrote:
 >
 >> Hi Paul,
 >> 
 >> I have changed my local code according your suggestions. If gpio is 
 >> available in the kernel configuration the kernel compiles and runs fine. If 
 >> the gpio attachement in kernel configuration is removed however the linker 
 >> complaining about unresolved symbol gpiobus_print. To be honest I already 
 >> expected a linker error without NGPIO preprocessor directives. I'm not 
 >> entirely sure how NetBSD make process is done, but I assume the 
 >> sys/gpio/gpio.c isn't compiled if not configured.
 >> I can add the NGPIO conditions again, but doubtful If the additional rescan 
 >> is still useful.
 >
 > Hmmm.  I would have to think about this further.
 
 Yeah, for now let's ignore the modular aspects.  Hopefully someone with 
 more knowledge about the platform can review and import your original 
 driver.
 
 At some future time, we should probably extract gpiobus_print() (and any 
 other routines specific to the attachment attribute) into a separate 
 source file, rather than burying it in gpio.c  We might also need to 
 clean up all the other drivers that "provide" the attribute.  So, we're 
 not going to deal with it today.  :)
 
 
 +------------------+--------------------------+----------------------------+
 | Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:          |
 | (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com   |
 | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org |
 +------------------+--------------------------+----------------------------+