NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
kern/51936: src/sys/dev/isa/gus.c:1030: bad expression ?
>Number: 51936
>Category: kern
>Synopsis: src/sys/dev/isa/gus.c:1030: bad expression ?
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: kern-bug-people
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Wed Feb 01 19:05:00 +0000 2017
>Originator: David Binderman
>Release: cvs-20170201
>Organization:
>Environment:
>Description:
src/sys/dev/isa/gus.c:1030]: (style) Boolean result is used in bitwise operation. Clarify expression with parentheses.
Source code is
if ((sc->sc_revision >= 10) & !(HAS_CODEC(sc)))
Maybe better code
if ((sc->sc_revision >= 10) && !(HAS_CODEC(sc)))
>How-To-Repeat:
>Fix:
Home |
Main Index |
Thread Index |
Old Index