NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
port-atari/51933: sys/arch/atari/vme/leo.c: 2 * bad condition ?
>Number: 51933
>Category: port-atari
>Synopsis: sys/arch/atari/vme/leo.c: 2 * bad condition ?
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: port-atari-maintainer
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Wed Feb 01 14:25:00 +0000 2017
>Originator: David Binderman
>Release: cvs-20170201
>Organization:
>Environment:
>Description:
src/sys/arch/atari/vme/leo.c:336]: (style) Condition '255' is always true
Source code is
bus_space_write_1(sc->sc_iot, sc->sc_ioh, LEO_REG_MSBSCROLL,
(scroll >> 6) && 0xff);
maybe better code
bus_space_write_1(sc->sc_iot, sc->sc_ioh, LEO_REG_MSBSCROLL,
(scroll >> 6) & 0xff);
src/sys/arch/atari/vme/leo.c:338]: (style) Condition '255' is always true
Duplicate.
>How-To-Repeat:
>Fix:
Home |
Main Index |
Thread Index |
Old Index