Re: kern/51921: src/sys/arch/arm/arm/cpufunc.c:3079: possible typo ?

[Paul Goyette <paul%whooppee.com@localhost>]

The following reply was made to PR kern/51921; it has been noted by GNATS.

From: Paul Goyette <paul%whooppee.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Subject: Re: kern/51921: src/sys/arch/arm/arm/cpufunc.c:3079: possible typo
 ?
Date: Sun, 29 Jan 2017 07:45:55 +0800 (PHT)

 On Sat, 28 Jan 2017, dcb314%hotmail.com@localhost wrote:
 
 > Source code is
 >
 >    cpuctrl |= (0x5 << 16) | (1 < 22);
 >
 > But maybe this code was intended:
 >
 >    cpuctrl |= (0x5 << 16) | (1 << 22);
 
 In any case, we really should have meaningfully-named macros for these 
 values, rather than "magic numbers".
 
 
 
 +------------------+--------------------------+------------------------+
 | Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:      |
 | (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com   |
 | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd.org |
 +------------------+--------------------------+------------------------+