kern/51879: vs(4) audio attach failed

[isaki%NetBSD.org@localhost]

>Number:         51879
>Category:       kern
>Synopsis:       vs(4) audio attach failed
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jan 15 07:40:00 +0000 2017
>Originator:     Tetsuya Isaki
>Release:        NetBSD-current
>Organization:
NetBSD
>Environment:
NetBSD XXXXX 7.99.59 NetBSD 7.99.59 (GENERIC) #14: Sun Jan 15 14:30:05 JST 2017  isaki@XXXXX/sys/arch/x68k/compile/GENERIC x68k
>Description:
vs(4) audio attach failed in recent x68k kernel.

# dmesg
:
vs0 at intio0 addr 0xe92000 using DMA ch3 intr 0x6a and 0x6b
vs0: MSM6258V ADPCM voice synthesizer
audio0 at vs0: half duplex, playback, capture
Invalid channel format, please check hardware capabilities
vs0: audioattach: audio_set_vchan_defaults() failed
:

Before merging in-kernel mixer, audioattach() uses mu-law/8k/1ch
as default pparams and vs_set_params() (in arch/x68k/dev/vs.c)
supports it (because audioattach() required it).
Now audioattach() uses SLINEAR16/44.1k/2ch as default pparams
and vs_set_params() does not support either stereo or 44.1kHz freq.
Here vs(4) is up to 15.6kHz mono ADPCM device.

I don't know which is right...
 1) revert audioattach()'s default parameters to mu-law/8k/1ch.
or
 2) support SLINEAR16/44.1k/2ch to vs(4).

I think that MI/MD specification changes should be made carefully.
But I also think that SLINEAR16/44.1k/2ch may be reasonable than
mu-law/8k/1ch for most recent devices.
>How-To-Repeat:
Boot recent x68k kernel and see dmesg.
>Fix:
N/A