NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: PR/51840 CVS commit: src/tests/lib/libc/sys

The following reply was made to PR bin/51840; it has been noted by GNATS.

From: "Ngie Cooper (yaneurabeya)" <yaneurabeya%gmail.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: gnats-admin%netbsd.org@localhost,
 netbsd-bugs%netbsd.org@localhost
Subject: Re: PR/51840 CVS commit: src/tests/lib/libc/sys
Date: Fri, 13 Jan 2017 15:14:08 -0800

 --Apple-Mail=_B05214FB-8D70-4680-9A25-C37EBE38D909
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain;
 	charset=utf-8
 
 
 > On Jan 13, 2017, at 11:30 AM, Christos Zoulas <christos%netbsd.org@localhost> =
 wrote:
 >=20
 > The following reply was made to PR bin/51840; it has been noted by =
 GNATS.
 >=20
 > From: "Christos Zoulas" <christos%netbsd.org@localhost>
 > To: gnats-bugs%gnats.NetBSD.org@localhost
 > Cc:=20
 > Subject: PR/51840 CVS commit: src/tests/lib/libc/sys
 > Date: Fri, 13 Jan 2017 14:27:23 -0500
 >=20
 > Module Name:	src
 > Committed By:	christos
 > Date:		Fri Jan 13 19:27:23 UTC 2017
 >=20
 > Modified Files:
 > 	src/tests/lib/libc/sys: t_write.c
 >=20
 > Log Message:
 > PR/51840: Ngie Cooper: portability fixes for FreeBSD, etc
 >=20
 >=20
 > To generate a diff of this commit:
 > cvs rdiff -u -r1.2 -r1.3 src/tests/lib/libc/sys/t_write.c
 >=20
 > Please note that diffs are not public domain; they are subject to the
 > copyright notices on the relevant files.
 
 Is there a reason why the limits.h #include wasn=E2=80=99t added as =
 well? It=E2=80=99s needed for SIZE_MAX on FreeBSD (at least).
 Thanks,
 -Ngie
 
 $ cvs diff -u lib/libc/sys/t_write.c=20
 Index: lib/libc/sys/t_write.c
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /cvsroot/src/tests/lib/libc/sys/t_write.c,v
 retrieving revision 1.3
 diff -u -r1.3 t_write.c
 --- lib/libc/sys/t_write.c      13 Jan 2017 19:27:23 -0000      1.3
 +++ lib/libc/sys/t_write.c      13 Jan 2017 23:13:48 -0000
 @@ -36,6 +36,7 @@
  #include <atf-c.h>
  #include <errno.h>
  #include <fcntl.h>
 +#include <limits.h>
  #include <signal.h>
  #include <limits.h>
  #include <stdio.h>=
 
 --Apple-Mail=_B05214FB-8D70-4680-9A25-C37EBE38D909
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/html;
 	charset=utf-8
 
 <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html =
 charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; =
 -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" =
 class=3D""><br class=3D""><div><blockquote type=3D"cite" class=3D""><div =
 class=3D"">On Jan 13, 2017, at 11:30 AM, Christos Zoulas &lt;<a =
 href=3D"mailto:christos%netbsd.org@localhost"; class=3D"">christos%netbsd.org@localhost</a>&gt;=
  wrote:</div><br class=3D"Apple-interchange-newline"><div class=3D""><div =
 class=3D"">The following reply was made to PR bin/51840; it has been =
 noted by GNATS.<br class=3D""><br class=3D"">From: "Christos Zoulas" =
 &lt;<a href=3D"mailto:christos%netbsd.org@localhost"; =
 class=3D"">christos%netbsd.org@localhost</a>&gt;<br class=3D"">To: <a =
 href=3D"mailto:gnats-bugs%gnats.NetBSD.org@localhost"; =
 class=3D"">gnats-bugs%gnats.NetBSD.org@localhost</a><br class=3D"">Cc: <br =
 class=3D"">Subject: PR/51840 CVS commit: src/tests/lib/libc/sys<br =
 class=3D"">Date: Fri, 13 Jan 2017 14:27:23 -0500<br class=3D""><br =
 class=3D""> Module Name:<span class=3D"Apple-tab-span" =
 style=3D"white-space:pre">	</span>src<br class=3D""> Committed =
 By:<span class=3D"Apple-tab-span" style=3D"white-space:pre">	=
 </span>christos<br class=3D""> Date:<span class=3D"Apple-tab-span" =
 style=3D"white-space:pre">	</span><span class=3D"Apple-tab-span" =
 style=3D"white-space:pre">	</span>Fri Jan 13 19:27:23 UTC 2017<br =
 class=3D""><br class=3D""> Modified Files:<br class=3D""> <span =
 class=3D"Apple-tab-span" style=3D"white-space:pre">	=
 </span>src/tests/lib/libc/sys: t_write.c<br class=3D""><br class=3D""> =
 Log Message:<br class=3D""> PR/51840: Ngie Cooper: portability fixes for =
 FreeBSD, etc<br class=3D""><br class=3D""><br class=3D""> To generate a =
 diff of this commit:<br class=3D""> cvs rdiff -u -r1.2 -r1.3 =
 src/tests/lib/libc/sys/t_write.c<br class=3D""><br class=3D""> Please =
 note that diffs are not public domain; they are subject to the<br =
 class=3D""> copyright notices on the relevant files.<br =
 class=3D""></div></div></blockquote><br class=3D""></div><div>Is there a =
 reason why the limits.h #include wasn=E2=80=99t added as well? It=E2=80=99=
 s needed for SIZE_MAX on FreeBSD (at =
 least).</div><div>Thanks,</div><div>-Ngie</div><div><br =
 class=3D""></div><div><div style=3D"margin: 0px; line-height: normal; =
 font-family: 'Andale Mono'; color: rgb(40, 254, 20); background-color: =
 rgba(0, 0, 0, 0.901961);" class=3D""><span =
 style=3D"font-variant-ligatures: no-common-ligatures" class=3D"">$ cvs =
 diff -u lib/libc/sys/t_write.c&nbsp;</span></div><div style=3D"margin: =
 0px; line-height: normal; font-family: 'Andale Mono'; color: rgb(40, =
 254, 20); background-color: rgba(0, 0, 0, 0.901961);" class=3D""><span =
 style=3D"font-variant-ligatures: no-common-ligatures" class=3D"">Index: =
 lib/libc/sys/t_write.c</span></div><div style=3D"margin: 0px; =
 line-height: normal; font-family: 'Andale Mono'; color: rgb(40, 254, =
 20); background-color: rgba(0, 0, 0, 0.901961);" class=3D""><span =
 style=3D"font-variant-ligatures: no-common-ligatures" =
 class=3D"">=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D</span></di=
 v><div style=3D"margin: 0px; line-height: normal; font-family: 'Andale =
 Mono'; color: rgb(40, 254, 20); background-color: rgba(0, 0, 0, =
 0.901961);" class=3D""><span style=3D"font-variant-ligatures: =
 no-common-ligatures" class=3D"">RCS file: =
 /cvsroot/src/tests/lib/libc/sys/t_write.c,v</span></div><div =
 style=3D"margin: 0px; line-height: normal; font-family: 'Andale Mono'; =
 color: rgb(40, 254, 20); background-color: rgba(0, 0, 0, 0.901961);" =
 class=3D""><span style=3D"font-variant-ligatures: no-common-ligatures" =
 class=3D"">retrieving revision 1.3</span></div><div style=3D"margin: =
 0px; line-height: normal; font-family: 'Andale Mono'; color: rgb(40, =
 254, 20); background-color: rgba(0, 0, 0, 0.901961);" class=3D""><span =
 style=3D"font-variant-ligatures: no-common-ligatures" class=3D"">diff -u =
 -r1.3 t_write.c</span></div><div style=3D"margin: 0px; line-height: =
 normal; font-family: 'Andale Mono'; color: rgb(40, 254, 20); =
 background-color: rgba(0, 0, 0, 0.901961);" class=3D""><span =
 style=3D"font-variant-ligatures: no-common-ligatures" class=3D"">--- =
 lib/libc/sys/t_write.c&nbsp; &nbsp; &nbsp; 13 Jan 2017 19:27:23 =
 -0000&nbsp; &nbsp; &nbsp; 1.3</span></div><div style=3D"margin: 0px; =
 line-height: normal; font-family: 'Andale Mono'; color: rgb(40, 254, =
 20); background-color: rgba(0, 0, 0, 0.901961);" class=3D""><span =
 style=3D"font-variant-ligatures: no-common-ligatures" class=3D"">+++ =
 lib/libc/sys/t_write.c&nbsp; &nbsp; &nbsp; 13 Jan 2017 23:13:48 =
 -0000</span></div><div style=3D"margin: 0px; line-height: normal; =
 font-family: 'Andale Mono'; color: rgb(40, 254, 20); background-color: =
 rgba(0, 0, 0, 0.901961);" class=3D""><span =
 style=3D"font-variant-ligatures: no-common-ligatures" class=3D"">@@ =
 -36,6 +36,7 @@</span></div><div style=3D"margin: 0px; line-height: =
 normal; font-family: 'Andale Mono'; color: rgb(40, 254, 20); =
 background-color: rgba(0, 0, 0, 0.901961);" class=3D""><span =
 style=3D"font-variant-ligatures: no-common-ligatures" =
 class=3D"">&nbsp;#include &lt;atf-c.h&gt;</span></div><div =
 style=3D"margin: 0px; line-height: normal; font-family: 'Andale Mono'; =
 color: rgb(40, 254, 20); background-color: rgba(0, 0, 0, 0.901961);" =
 class=3D""><span style=3D"font-variant-ligatures: no-common-ligatures" =
 class=3D"">&nbsp;#include &lt;errno.h&gt;</span></div><div =
 style=3D"margin: 0px; line-height: normal; font-family: 'Andale Mono'; =
 color: rgb(40, 254, 20); background-color: rgba(0, 0, 0, 0.901961);" =
 class=3D""><span style=3D"font-variant-ligatures: no-common-ligatures" =
 class=3D"">&nbsp;#include &lt;fcntl.h&gt;</span></div><div =
 style=3D"margin: 0px; line-height: normal; font-family: 'Andale Mono'; =
 color: rgb(40, 254, 20); background-color: rgba(0, 0, 0, 0.901961);" =
 class=3D""><span style=3D"font-variant-ligatures: no-common-ligatures" =
 class=3D"">+#include &lt;limits.h&gt;</span></div><div style=3D"margin: =
 0px; line-height: normal; font-family: 'Andale Mono'; color: rgb(40, =
 254, 20); background-color: rgba(0, 0, 0, 0.901961);" class=3D""><span =
 style=3D"font-variant-ligatures: no-common-ligatures" =
 class=3D"">&nbsp;#include &lt;signal.h&gt;</span></div><div =
 style=3D"margin: 0px; line-height: normal; font-family: 'Andale Mono'; =
 color: rgb(40, 254, 20); background-color: rgba(0, 0, 0, 0.901961);" =
 class=3D""><span style=3D"font-variant-ligatures: no-common-ligatures" =
 class=3D"">&nbsp;#include &lt;limits.h&gt;</span></div><div =
 style=3D"margin: 0px; line-height: normal; font-family: 'Andale Mono'; =
 color: rgb(40, 254, 20); background-color: rgba(0, 0, 0, 0.901961);" =
 class=3D""><span style=3D"font-variant-ligatures: no-common-ligatures" =
 class=3D"">&nbsp;#include =
 &lt;stdio.h&gt;</span></div></div></body></html>=
 
 --Apple-Mail=_B05214FB-8D70-4680-9A25-C37EBE38D909--
Home | Main Index | Thread Index | Old Index