Re: PR/51569 CVS commit: src/crypto/external/bsd/openssl/dist/crypto/bn/asm

[Joerg Sonnenberger <joerg%bec.de@localhost>]

The following reply was made to PR lib/51569; it has been noted by GNATS.

From: Joerg Sonnenberger <joerg%bec.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: lib-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
	netbsd-bugs%netbsd.org@localhost, Andreas Gustafsson <gson%gson.org@localhost>
Subject: Re: PR/51569 CVS commit:
 src/crypto/external/bsd/openssl/dist/crypto/bn/asm
Date: Mon, 9 Jan 2017 21:03:48 +0100

 On Mon, Jan 09, 2017 at 03:50:01PM +0000, Andreas Gustafsson wrote:
 >  I think the change to x86_64-gf2m.pl worked simply because the added
 >  "+4" caused the regexp not to match, so that the @GOTPCREL was not
 >  added.  Other than that, it seems to me the old and new code should
 >  give the same result (i.e., test the same bit).  Now that the
 >  @GOTPCREL hack is gone from the Makefile, there should no longer be
 >  any need for the change to x86_64-gf2m.pl, so I think it should be
 >  reverted in the interest of keeping the differences wrt upstream
 >  minimal.
 
 The original version penalizes both in terms of code size and
 unnecessary unaligned access. Don't just revert to that crap.
 
 Joerg