NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: PR/51569 CVS commit: src/crypto/external/bsd/openssl/dist/crypto/bn/asm

On Mon, Jan 09, 2017 at 03:50:01PM +0000, Andreas Gustafsson wrote:
>  I think the change to worked simply because the added
>  "+4" caused the regexp not to match, so that the @GOTPCREL was not
>  added.  Other than that, it seems to me the old and new code should
>  give the same result (i.e., test the same bit).  Now that the
>  @GOTPCREL hack is gone from the Makefile, there should no longer be
>  any need for the change to, so I think it should be
>  reverted in the interest of keeping the differences wrt upstream
>  minimal.

The original version penalizes both in terms of code size and
unnecessary unaligned access. Don't just revert to that crap.


Home | Main Index | Thread Index | Old Index