Re: bin/51116: resize_ffs has problems with non-zero filled expansion of an ffsv2 filesystem

[Brad Spencer <brad%anduin.eldar.org@localhost>]

David Holland <dholland-bugs%netbsd.org@localhost> writes:

[snip]

>  On Thu, May 05, 2016 at 08:25:00PM +0000, brad%anduin.eldar.org@localhost wrote:
>   > I narrowed the issue down to ffsv2 filesystems that are expanded in a
>   > non zero-filled manor.
>  
>  I think the problem is that resize_ffs is not handling ffsv2's
>  deferred inode initialization correctly.
>  
>  It does
>  
>  	cg->cg_initediblk = newsb->fs_ipg < 2 * FFS_INOPB(newsb) ?
>  	    newsb->fs_ipg : 2 * FFS_INOPB(newsb);
>  
>  (line 497 in initcg) which declares that two blocks' worth of inodes
>  have been written out zeroed, but then later (at line 619) it doesn't
>  write the inodes out at all if ffsv2.
>  
>  If this is the problem the following 100% untested patch might improve
>  the situation:
>  
[snip]

>  
>  -- 
>  David A. Holland
>  dholland%netbsd.org@localhost
>  


I applied the 100% untested patch to a NetBSD 7.x system and tested it.
I was not able to reproduce the problem I saw with the unpatched
resize_ffs which suggests that the patch improves the situation.  I
would suggest that this patch should be applied to the code and pulled
into 7.x if possible.

Thanks for looking into this.



-- 
Brad Spencer - brad%anduin.eldar.org@localhost - KC8VKS
http://anduin.eldar.org  - & -  http://anduin.ipv6.eldar.org [IPv6 only]