[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: kern/48277: Booting under KVM yields panic: siop_intr: I shouldn't be there !
The following reply was made to PR kern/48277; it has been noted by GNATS.
From: Andreas Gustafsson <gson%gson.org@localhost>
To: gnats-bugs%NetBSD.org@localhost, Martin Husemann
<martin%duskware.de@localhost>, Manuel Bouyer <bouyer%antioche.eu.org@localhost>
Subject: Re: kern/48277: Booting under KVM yields panic: siop_intr: I shouldn't
be there !
Date: Wed, 30 Oct 2013 10:56:05 +0200
Martin Husemann wrote:
> The printf should be conditionalized on SIOP_DEBUG_INTR and the return
> should be "return retval;" - otherwise the change looks good enough to
> go in.
And Manuel Bouyer replied:
> No, if you want to remove the panic the printf should stay
I concur with Manuel. Furthermore, I don't see the point in changing
the "return 1;" to "return retval;", because retval will always be 1
at that point in the code, and other return statements in the vicinity
already say "return 1;", so "return 1;" seems simpler, clearer, and
more consistent with the existing code.
Unless there are other objections, I will change the panic into an
unconditional printf followed by "return 1;".
Andreas Gustafsson, gson%gson.org@localhost
Main Index |
Thread Index |