Re: misc/47827: [PATCH] improve portability of NetBSD libc testcases

[Garrett Cooper <yaneurabeya%gmail.com@localhost>]

The following reply was made to PR misc/47827; it has been noted by GNATS.

From: Garrett Cooper <yaneurabeya%gmail.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: misc-bug-people%netbsd.org@localhost,
 gnats-admin%netbsd.org@localhost,
 netbsd-bugs%netbsd.org@localhost,
 sjg%NetBSD.org@localhost
Subject: Re: misc/47827: [PATCH] improve portability of NetBSD libc testcases
Date: Fri, 17 May 2013 13:17:47 -0400

 On May 17, 2013, at 1:05 PM, Garrett Cooper wrote:
 
 > The following reply was made to PR misc/47827; it has been noted by =
 GNATS.
 >=20
 > From: Garrett Cooper <yaneurabeya%gmail.com@localhost>
 > To: gnats-bugs%NetBSD.org@localhost
 > Cc:=20
 > Subject: Re: misc/47827: [PATCH] improve portability of NetBSD libc =
 testcases
 > Date: Fri, 17 May 2013 13:01:22 -0400
 >=20
 > --Apple-Mail=3D_0E583C49-25B9-45D5-B267-BB90A76B8167
 > Content-Transfer-Encoding: 7bit
 > Content-Type: text/plain;
 >      charset=3Dus-ascii
 >=20
 >      Here's the initial patch.
 > Thanks!
 > -Garrett
 >=20
 >=20
 > --Apple-Mail=3D_0E583C49-25B9-45D5-B267-BB90A76B8167
 > Content-Disposition: attachment;
 >      filename=3Dnetbsd-libc-test-portability-fixes.patch
 > Content-Type: application/octet-stream;
 >      name=3D"netbsd-libc-test-portability-fixes.patch"
 > Content-Transfer-Encoding: 7bit
 >=20
 > Index: tests/lib/libc/Makefile.inc
 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 > RCS file: /cvsroot/src/tests/lib/libc/Makefile.inc,v
 > retrieving revision 1.1
 > diff -u -r1.1 Makefile.inc
 > --- tests/lib/libc/Makefile.inc      3 Nov 2010 16:10:21 -0000       =
 1.1
 > +++ tests/lib/libc/Makefile.inc      17 May 2013 16:00:42 -0000
 > @@ -1 +1,3 @@
 > +CFLAGS+=3D  -I${.CURDIR:H:H}
 > +
 
        I forgot that NetBSD has a more sane (and correct) way of =
 representing this:
 
 CFLAGS+=3D     -I${NETBSDSRCDIR}/tests
 
        The above form works for me because I can't go more than two =
 levels deep in the libc tests directory I've imported because of missing =
 build changes in FreeBSD that I'm not willing/able to fix quite yet as =
 our copy of bsd.progs.mk doesn't support directory traversal and =
 specifying PROG*/SCRIPTS* out of the box.
 Cheers!
 -Garrett=