PR/46930 CVS commit: src/crypto/external/bsd/netpgp

["Alistair G. Crooks" <agc%netbsd.org@localhost>]

The following reply was made to PR bin/46930; it has been noted by GNATS.

From: "Alistair G. Crooks" <agc%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/46930 CVS commit: src/crypto/external/bsd/netpgp
Date: Tue, 20 Nov 2012 05:26:27 +0000

 Module Name:   src
 Committed By:  agc
 Date:          Tue Nov 20 05:26:26 UTC 2012
 
 Modified Files:
        src/crypto/external/bsd/netpgp: Makefile
 Added Files:
        src/crypto/external/bsd/netpgp/bin: Makefile
        src/crypto/external/bsd/netpgp/bin/netpgpverify: Makefile
        src/crypto/external/bsd/netpgp/dist/src/libbn: Makefile bignum.c bn.h
            libnetpgpbn.3 misc.c misc.h rand.c rand.h stubs.c stubs.h
        src/crypto/external/bsd/netpgp/dist/src/libdigest: Makefile digest.c
            digest.h tiger.3 tiger.c tiger.h
        src/crypto/external/bsd/netpgp/dist/src/librsa: Makefile libnetpgprsa.3
            rsa.c rsa.h rsastubs.c rsastubs.h
        src/crypto/external/bsd/netpgp/dist/src/libverify: Makefile array.h
            b64.c b64.h dump.c libnetpgpverify.3 libverify.c pgpsum.c pgpsum.h
            verify.h
        src/crypto/external/bsd/netpgp/dist/src/netpgpverify: main.c
        src/crypto/external/bsd/netpgp/lib/verify: Makefile shlib_version
 
 Log Message:
 Merge netpgpverify(1) and libnetpgpverify(3) from the
 agc-netpgp-standalone branch.
 
 Rewrite the netpgpverify(1) functionality from RFC4880 up.  This is a
 completely new implementation, and uses its own bignum library derived
 from libtommath.  Apart from libz and libbz2, it just uses its own
 library and is self-contained - this makes it easier to embed, and to
 use from scripting languages.
 
 netpgpverify(1) now verifies all the signed files i've thrown at it,
 and the added bonus of using no functionality from libcrypto - all of
 its bignum functionality comes from its own libnetpgpverify.so.
 netpgpverify(1) now verifies not only signatures on binary files, but
 also signatures on text documents.  This fixes PR/46930.  Please don't
 start me on the hoops I had to jump through to calculate the digests
 on text files; trust me, you will regret it.
 
 % supersize `which netpgpverify`
    text    data     bss     dec     hex filename
    4452     860      72    5384    1508 /usr/bin/netpgpverify
   79542    1408       0   80950   13c36 /usr/lib/libz.so.1
   43994     984     488   45466    b19a /usr/lib/libgcc_s.so.1
 1318116   49644   69272 1437032  15ed68 /usr/lib/libc.so.12
   57253    4184       0   61437    effd /usr/lib/libbz2.so.1
  108726    1712       0  110438   1af66 /usr/lib/libnetpgpverify.so.4
   1612083    58792   69832   1740707   0x1a8fa3   total
 %
 
 % make t
 env LD_LIBRARY_PATH=/usr/src/crypto/external/bsd/netpgp-standalone/lib/verify 
./netpgpverify -c verify b.gpg > output16
 diff expected16 output16
 rm -f output16
 env LD_LIBRARY_PATH=/usr/src/crypto/external/bsd/netpgp-standalone/lib/verify 
./netpgpverify -c verify a.gpg > output17
 diff expected17 output17
 rm -f output17
 env LD_LIBRARY_PATH=/usr/src/crypto/external/bsd/netpgp-standalone/lib/verify 
./netpgpverify -c verify gpgsigned-a.gpg > output18
 diff expected18 output18
 rm -f output18
 env LD_LIBRARY_PATH=/usr/src/crypto/external/bsd/netpgp-standalone/lib/verify 
./netpgpverify -c verify NetBSD-6.0_RC2_hashes.asc > output19
 diff expected19 output19
 rm -f output19
 ...
 env LD_LIBRARY_PATH=/usr/src/crypto/external/bsd/netpgp-standalone/lib/verify 
./netpgpverify -k dsa-pubring.gpg in2.asc > output45
 diff expected45 output45
 rm -f output45
 env LD_LIBRARY_PATH=/usr/src/crypto/external/bsd/netpgp-standalone/lib/verify 
./netpgpverify -k problem-pubring.gpg NetBSD-6.0_hashes.asc > output46
 diff expected46 output46
 rm -f output46
 cd tests/netpgpverify && make && atf-run
 atf2kyua: I: Removing stale Kyuafiles from /tmp/.XXXXXX.004966aa
 atf2kyua: I: Converting 
/usr/src/crypto/external/bsd/netpgp-standalone/tests/netpgpverify/Atffile -> 
/tmp/.XXXXXX.004966aa/Kyuafile
 t_netpgpverify:netpgpverify_rsa  ->  passed  [0.221s]
 t_netpgpverify:netpgpverify_dsa  ->  passed  [0.117s]
 
 2/2 passed (0 failed)
 Committed action 19
 %
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.5 -r1.6 src/crypto/external/bsd/netpgp/Makefile
 cvs rdiff -u -r0 -r1.4 src/crypto/external/bsd/netpgp/bin/Makefile
 cvs rdiff -u -r0 -r1.2 \
     src/crypto/external/bsd/netpgp/bin/netpgpverify/Makefile
 cvs rdiff -u -r0 -r1.2 src/crypto/external/bsd/netpgp/dist/src/libbn/Makefile \
     src/crypto/external/bsd/netpgp/dist/src/libbn/bignum.c \
     src/crypto/external/bsd/netpgp/dist/src/libbn/bn.h \
     src/crypto/external/bsd/netpgp/dist/src/libbn/libnetpgpbn.3 \
     src/crypto/external/bsd/netpgp/dist/src/libbn/misc.c \
     src/crypto/external/bsd/netpgp/dist/src/libbn/misc.h \
     src/crypto/external/bsd/netpgp/dist/src/libbn/rand.c \
     src/crypto/external/bsd/netpgp/dist/src/libbn/rand.h \
     src/crypto/external/bsd/netpgp/dist/src/libbn/stubs.c \
     src/crypto/external/bsd/netpgp/dist/src/libbn/stubs.h
 cvs rdiff -u -r0 -r1.2 \
     src/crypto/external/bsd/netpgp/dist/src/libdigest/Makefile \
     src/crypto/external/bsd/netpgp/dist/src/libdigest/digest.c \
     src/crypto/external/bsd/netpgp/dist/src/libdigest/digest.h \
     src/crypto/external/bsd/netpgp/dist/src/libdigest/tiger.3 \
     src/crypto/external/bsd/netpgp/dist/src/libdigest/tiger.c \
     src/crypto/external/bsd/netpgp/dist/src/libdigest/tiger.h
 cvs rdiff -u -r0 -r1.2 \
     src/crypto/external/bsd/netpgp/dist/src/librsa/Makefile \
     src/crypto/external/bsd/netpgp/dist/src/librsa/libnetpgprsa.3 \
     src/crypto/external/bsd/netpgp/dist/src/librsa/rsa.c \
     src/crypto/external/bsd/netpgp/dist/src/librsa/rsa.h \
     src/crypto/external/bsd/netpgp/dist/src/librsa/rsastubs.c \
     src/crypto/external/bsd/netpgp/dist/src/librsa/rsastubs.h
 cvs rdiff -u -r0 -r1.2 \
     src/crypto/external/bsd/netpgp/dist/src/libverify/Makefile \
     src/crypto/external/bsd/netpgp/dist/src/libverify/array.h \
     src/crypto/external/bsd/netpgp/dist/src/libverify/b64.c \
     src/crypto/external/bsd/netpgp/dist/src/libverify/b64.h \
     src/crypto/external/bsd/netpgp/dist/src/libverify/dump.c \
     src/crypto/external/bsd/netpgp/dist/src/libverify/libnetpgpverify.3 \
     src/crypto/external/bsd/netpgp/dist/src/libverify/libverify.c \
     src/crypto/external/bsd/netpgp/dist/src/libverify/pgpsum.c \
     src/crypto/external/bsd/netpgp/dist/src/libverify/pgpsum.h \
     src/crypto/external/bsd/netpgp/dist/src/libverify/verify.h
 cvs rdiff -u -r0 -r1.2 \
     src/crypto/external/bsd/netpgp/dist/src/netpgpverify/main.c
 cvs rdiff -u -r0 -r1.2 src/crypto/external/bsd/netpgp/lib/verify/Makefile \
     src/crypto/external/bsd/netpgp/lib/verify/shlib_version
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.