Re: port-xen/47193: xenwatch handlers are added twice to the list of pending watches

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

The following reply was made to PR port-xen/47193; it has been noted by GNATS.

From: Manuel Bouyer <bouyer%antioche.eu.org@localhost>
To: Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau%citrix.com@localhost>
Cc: "Cherry G.Mathew" <cherry%zyx.in@localhost>,
        "gnats-bugs%NetBSD.org@localhost" <gnats-bugs%NetBSD.org@localhost>,
        "port-xen-maintainer%netbsd.org@localhost" 
<port-xen-maintainer%NetBSD.org@localhost>,
        "netbsd-bugs%netbsd.org@localhost" <netbsd-bugs%NetBSD.org@localhost>
Subject: Re: port-xen/47193: xenwatch handlers are added twice to the list of
 pending watches
Date: Mon, 19 Nov 2012 20:28:26 +0100

 On Mon, Nov 19, 2012 at 07:49:44PM +0100, Roger Pau Monné wrote:
 > > I don't know why gcc doesn't complain about repeated being possibly
 > > uninitialised here. AFAIK repeated is initialised only in the found case.
 > > repeated = false should probably be moved upper.
 > 
 > I guess because if "repeated" is not initialized, it is not even
 > checked, since the first part of the if condition "if (!found)" will
 > always be true.
 
 Right. But I guess the waring would trip with different optimisation
 options.
 
 > I will move the initialization upper.
 
 thanks
 
 -- 
 Manuel Bouyer <bouyer%antioche.eu.org@localhost>
      NetBSD: 26 ans d'experience feront toujours la difference
 --