Re: bin/46733: makemandb always lists links as changed pages

[Abhinav Upadhyay <er.abhinav.upadhyay%gmail.com@localhost>]

The following reply was made to PR bin/46733; it has been noted by GNATS.

From: Abhinav Upadhyay <er.abhinav.upadhyay%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: bin/46733: makemandb always lists links as changed pages
Date: Thu, 9 Aug 2012 11:37:30 +0530

 On Sun, Jul 22, 2012 at 1:05 PM, Abhinav Upadhyay
 <er.abhinav.upadhyay%gmail.com@localhost> wrote:
 >
 > On Sun, Jul 22, 2012 at 5:10 AM,  <lloyd%must-have-coffee.gen.nz@localhost> 
 > wrote:
 > >>Number:         46733
 > >>Category:       bin
 > >>Synopsis:       makemandb always lists links as changed pages
 > >>Confidential:   no
 > >>Severity:       non-critical
 > >>Priority:       low
 > >>Responsible:    bin-bug-people
 > >>State:          open
 > >>Class:          sw-bug
 > >>Submitter-Id:   net
 > >>Arrival-Date:   Sat Jul 21 23:40:00 +0000 2012
 > >>Originator:     Lloyd Parkes
 > >>Release:        NetBSD 6.0_BETA2
 > >>Organization:
 > > Must Have Coffee
 > >>Environment:
 > > System: NetBSD thallid.must-have-coffee.gen.nz 6.0_BETA2 NetBSD
 > > 6.0_BETA2 (XEN3PAE_DOMU) #0: Mon Jun 18 04:48:20 NZST 2012
 > > lloyd@bob:/vol/scratch/build6/obj.i386/sys/arch/i386/compile/XEN3PAE_DOMU
 > > i386
 > > Architecture: i386
 > > Machine: i386
 > >>Description:
 > >
 > > makemandb always reports the same number for "Total Number of new or
 > > updated pages enountered" and "Total number of (hard or symbolic)
 > > links found".
 > >
 > > e.g.
 > >
 > > Updating man page index:
 > > Building temporary file cache
 > > Total Number of new or updated pages enountered = 446
 > > Total number of pages that were successfully indexed/updated = 0
 > > Total number of (hard or symbolic) links found = 446
 > > Total number of pages that could not be indexed due to errors = 0
 > > Deleting stale index entries
 > >
 > >>How-To-Repeat:
 > >
 > > Run makemandb twice in quite succession. Note that the second time
 > > it is run, it still reports new or updated man pages even though
 > > no new man pages have been installed.
 >
 > >>Fix:
 > > I haven't looked for a fix.
 > >
 >
 > Index: makemandb.c
 > ===================================================================
 > RCS file: /cvsroot/src/usr.sbin/makemandb/makemandb.c,v
 > retrieving revision 1.10
 > diff -u -p -r1.10 makemandb.c
 > --- makemandb.c 8 Jul 2012 23:18:23 -0000       1.10
 > +++ makemandb.c 22 Jul 2012 07:26:51 -0000
 > @@ -764,12 +764,12 @@ update_db(sqlite3 *db, struct mparse *mp
 >
 >         if (mflags.verbosity) {
 >                 printf("Total Number of new or updated pages encountered =
 > %d\n"
 > +                       "Total number of (hard or symbolic) links found =
 > %d\n"
 >                         "Total number of pages that were successfully"
 >                         " indexed/updated = %d\n"
 > -                       "Total number of (hard or symbolic) links found =
 > %d\n"
 >                         "Total number of pages that could not be indexed"
 >                         " due to errors = %d\n",
 > -                       total_count, new_count, link_count, err_count);
 > +                       total_count - link_count, link_count,
 > new_count, err_count);
 >         }
 >
 >         if (mflags.recreate)
 
 Would someone please review and commit this or if it is not required
 then close this PR :)
 
 
 --
 Abhinav