Re: bin/46733: makemandb always lists links as changed pages

[Abhinav Upadhyay <er.abhinav.upadhyay%gmail.com@localhost>]

The following reply was made to PR bin/46733; it has been noted by GNATS.

From: Abhinav Upadhyay <er.abhinav.upadhyay%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Subject: Re: bin/46733: makemandb always lists links as changed pages
Date: Sun, 22 Jul 2012 13:05:25 +0530

 --90e6ba21215b2d1bad04c5662cab
 Content-Type: text/plain; charset=ISO-8859-1
 
 On Sun, Jul 22, 2012 at 5:10 AM,  <lloyd%must-have-coffee.gen.nz@localhost> 
wrote:
 >>Number:         46733
 >>Category:       bin
 >>Synopsis:       makemandb always lists links as changed pages
 >>Confidential:   no
 >>Severity:       non-critical
 >>Priority:       low
 >>Responsible:    bin-bug-people
 >>State:          open
 >>Class:          sw-bug
 >>Submitter-Id:   net
 >>Arrival-Date:   Sat Jul 21 23:40:00 +0000 2012
 >>Originator:     Lloyd Parkes
 >>Release:        NetBSD 6.0_BETA2
 >>Organization:
 > Must Have Coffee
 >>Environment:
 > System: NetBSD thallid.must-have-coffee.gen.nz 6.0_BETA2 NetBSD 6.0_BETA2 
 > (XEN3PAE_DOMU) #0: Mon Jun 18 04:48:20 NZST 2012 
 > lloyd@bob:/vol/scratch/build6/obj.i386/sys/arch/i386/compile/XEN3PAE_DOMU 
 > i386
 > Architecture: i386
 > Machine: i386
 >>Description:
 >
 > makemandb always reports the same number for "Total Number of new or
 > updated pages enountered" and "Total number of (hard or symbolic)
 > links found".
 >
 > e.g.
 >
 > Updating man page index:
 > Building temporary file cache
 > Total Number of new or updated pages enountered = 446
 > Total number of pages that were successfully indexed/updated = 0
 > Total number of (hard or symbolic) links found = 446
 > Total number of pages that could not be indexed due to errors = 0
 > Deleting stale index entries
 >
 >>How-To-Repeat:
 >
 > Run makemandb twice in quite succession. Note that the second time
 > it is run, it still reports new or updated man pages even though
 > no new man pages have been installed.
 
 >>Fix:
 > I haven't looked for a fix.
 >
 
 Index: makemandb.c
 ===================================================================
 RCS file: /cvsroot/src/usr.sbin/makemandb/makemandb.c,v
 retrieving revision 1.10
 diff -u -p -r1.10 makemandb.c
 --- makemandb.c 8 Jul 2012 23:18:23 -0000       1.10
 +++ makemandb.c 22 Jul 2012 07:26:51 -0000
 @@ -764,12 +764,12 @@ update_db(sqlite3 *db, struct mparse *mp
 
         if (mflags.verbosity) {
                 printf("Total Number of new or updated pages encountered = 
%d\n"
 +                       "Total number of (hard or symbolic) links found = %d\n"
                         "Total number of pages that were successfully"
                         " indexed/updated = %d\n"
 -                       "Total number of (hard or symbolic) links found = %d\n"
                         "Total number of pages that could not be indexed"
                         " due to errors = %d\n",
 -                       total_count, new_count, link_count, err_count);
 +                       total_count - link_count, link_count,
 new_count, err_count);
         }
 
         if (mflags.recreate)
 
 --90e6ba21215b2d1bad04c5662cab
 Content-Type: application/octet-stream; name="makemandb.c.diff"
 Content-Disposition: attachment; filename="makemandb.c.diff"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_h4xt4v7p0
 
 SW5kZXg6IG1ha2VtYW5kYi5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnNyb290L3NyYy91c3Iu
 c2Jpbi9tYWtlbWFuZGIvbWFrZW1hbmRiLmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTAKZGlm
 ZiAtdSAtcCAtcjEuMTAgbWFrZW1hbmRiLmMKLS0tIG1ha2VtYW5kYi5jIDggSnVsIDIwMTIgMjM6
 MTg6MjMgLTAwMDAgICAgICAgMS4xMAorKysgbWFrZW1hbmRiLmMgMjIgSnVsIDIwMTIgMDc6MjY6
 NTEgLTAwMDAKQEAgLTc2NCwxMiArNzY0LDEyIEBAIHVwZGF0ZV9kYihzcWxpdGUzICpkYiwgc3Ry
 dWN0IG1wYXJzZSAqbXAKICAgICAgICAKICAgICAgICBpZiAobWZsYWdzLnZlcmJvc2l0eSkgewog
 ICAgICAgICAgICAgICAgcHJpbnRmKCJUb3RhbCBOdW1iZXIgb2YgbmV3IG9yIHVwZGF0ZWQgcGFn
 ZXMgZW5jb3VudGVyZWQgPSAlZFxuIgorICAgICAgICAgICAgICAgICAgICAgICAiVG90YWwgbnVt
 YmVyIG9mIChoYXJkIG9yIHN5bWJvbGljKSBsaW5rcyBmb3VuZCA9ICVkXG4iCiAgICAgICAgICAg
 ICAgICAgICAgICAgICJUb3RhbCBudW1iZXIgb2YgcGFnZXMgdGhhdCB3ZXJlIHN1Y2Nlc3NmdWxs
 eSIKICAgICAgICAgICAgICAgICAgICAgICAgIiBpbmRleGVkL3VwZGF0ZWQgPSAlZFxuIgotICAg
 ICAgICAgICAgICAgICAgICAgICAiVG90YWwgbnVtYmVyIG9mIChoYXJkIG9yIHN5bWJvbGljKSBs
 aW5rcyBmb3VuZCA9ICVkXG4iCiAgICAgICAgICAgICAgICAgICAgICAgICJUb3RhbCBudW1iZXIg
 b2YgcGFnZXMgdGhhdCBjb3VsZCBub3QgYmUgaW5kZXhlZCIKICAgICAgICAgICAgICAgICAgICAg
 ICAgIiBkdWUgdG8gZXJyb3JzID0gJWRcbiIsCi0gICAgICAgICAgICAgICAgICAgICAgIHRvdGFs
 X2NvdW50LCBuZXdfY291bnQsIGxpbmtfY291bnQsIGVycl9jb3VudCk7CisgICAgICAgICAgICAg
 ICAgICAgICAgIHRvdGFsX2NvdW50IC0gbGlua19jb3VudCwgbGlua19jb3VudCwgbmV3X2NvdW50
 LCBlcnJfY291bnQpOwogICAgICAgIH0KIAogICAgICAgIGlmIChtZmxhZ3MucmVjcmVhdGUpCg==
 --90e6ba21215b2d1bad04c5662cab--