Re: kern/42570: Wacom's Graphire USB tablet does not bedistinguished from Graphire3 etc.

[Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>]

Hi,

> From: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>
> To: gnats-bugs%NetBSD.org@localhost
> Cc: kern-bug-people%NetBSD.org@localhost, ryo_on%yk.rim.or.jp@localhost, 
> tsutsui%ceres.dti.ne.jp@localhost
> Subject: Re: kern/42570: Wacom's Graphire USB tablet does not bedistinguished
>        from Graphire3 etc.
> Date: Tue, 19 Jul 2011 23:31:11 +0900
> 
>  >  My explanation is not sufficient.
>  >  
>  >  The key is sending 0x2020 before using.
>  >  The current descriptor is wrong, but with only stylus works.
>  >  With 4D mouse, does not works.
>  >  
>  >  If NetBSD support fully Graphire, my description is needed.
>  
>  Only stylus works (but not 4D mouse) with the current descriptor?
>  Does 4D mouse work with the Graphire3's one?
>  
>  If so it's okay to apply your changes, but it might be better to leave
>  the old descriptor by wrapping #if 0/#endif and note the above
>  description.
>  (0x0202 should be written to feature report ID 2 even on
>   the original Graphire etc.)

Now, I cannot find my 4D mouse in my room, sorry.
If I recall correctly, old descriptor doesn't support 4D mouse's buttons.

Following is minimal patch for Graphire as stylus only tablet.

I feel, at least, this patch should be committed.

Thank you.

Index: uhidev.c
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/uhidev.c,v
retrieving revision 1.49
diff -u -r1.49 uhidev.c
--- uhidev.c    29 Jan 2011 14:20:18 -0000      1.49
+++ uhidev.c    19 Jul 2011 15:47:46 -0000
@@ -193,6 +193,12 @@
                /* The report descriptor for the Wacom Graphire is broken. */
                switch (uaa->product) {
                case USB_PRODUCT_WACOM_GRAPHIRE:
+                       /*
+                        * Graphire also needs 0x0202 like Graphire2.
+                        */
+                       usbd_set_report(uaa->iface, UHID_FEATURE_REPORT, 2,
+                           &reportbuf, sizeof reportbuf);
+
                        size = sizeof uhid_graphire_report_descr;
                        descptr = uhid_graphire_report_descr;
                        break;

--
Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3