Re: kern/45156: Patch to support XS Stick P14 USB 3G Modem and similar devices

[David Laight <david%l8s.co.uk@localhost>]

The following reply was made to PR kern/45156; it has been noted by GNATS.

From: David Laight <david%l8s.co.uk@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/45156: Patch to support XS Stick P14 USB 3G Modem and similar 
devices
Date: Mon, 18 Jul 2011 17:37:14 +0100

 On Mon, Jul 18, 2011 at 09:20:03AM +0000, Moritz Wilhelmy wrote:
 > The following reply was made to PR kern/45156; it has been noted by GNATS.
 > 
 > From: Moritz Wilhelmy <moritz%wzff.de@localhost>
 > To: gnats-bugs%NetBSD.org@localhost
 > Cc: 
 > Subject: Re: kern/45156: Patch to support XS Stick P14 USB 3G Modem and
 >  similar devices
 > Date: Mon, 18 Jul 2011 11:15:10 +0200
 > 
 >  On Mon, Jul 18, 2011 at 07:05:03 +0000, David Laight wrote:
 >  >  Why not a 'static const magic_cmd[31] = { 0x55, ....
 >  
 >  The code around it did it that way, but you're right, it'd be shorter,
 >  because it contains less zeroes than the other devices.
 
 That isn't the point, since none of the bytes are variable you don't
 need an on-stack buffer, a compile-time initialised one will do.
 
        David
 
 -- 
 David Laight: david%l8s.co.uk@localhost