Re: kern/45156: Patch to support XS Stick P14 USB 3G Modem and similar devices

[David Laight <david%l8s.co.uk@localhost>]

The following reply was made to PR kern/45156; it has been noted by GNATS.

From: David Laight <david%l8s.co.uk@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/45156: Patch to support XS Stick P14 USB 3G Modem and similar 
devices
Date: Mon, 18 Jul 2011 08:01:31 +0100

 On Sun, Jul 17, 2011 at 09:20:00PM +0000, Moritz Wilhelmy wrote:
 > >Number:         45156
 > >Category:       kern
 > >Synopsis:       Patch to support XS Stick P14 USB 3G Modem and similar 
 > >devices
 ...
 >  static int
 > +u3g_unknown_1c9e_reinit(usbd_device_handle dev)
 > +{
 > +    unsigned char cmd[31];
 > +
 > +    /* magic string adapted from usb_modeswitch database */
 > +    memset(cmd, 0, sizeof(cmd));
 > +    cmd[0] = 0x55; 
 > +    cmd[1] = 0x53;
 > +    cmd[2] = 0x42;
 ...
 > +    cmd[19]= 0x52;
 > +    cmd[20]= 0x70;
 
 Why not a 'static const magic_cmd[31] = { 0x55, ....
 
        David
 
 -- 
 David Laight: david%l8s.co.uk@localhost