Re: PR/44405 CVS commit: src/sys/arch/amd64/amd64

[Wolfgang Stukenbrock <Wolfgang.Stukenbrock%nagler-company.com@localhost>]

The following reply was made to PR port-amd64/44405; it has been noted by GNATS.

From: Wolfgang Stukenbrock <Wolfgang.Stukenbrock%nagler-company.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: port-amd64-maintainer%NetBSD.org@localhost, 
gnats-admin%NetBSD.org@localhost,
        netbsd-bugs%NetBSD.org@localhost, 
Wolfgang.Stukenbrock%nagler-company.com@localhost
Subject: Re: PR/44405 CVS commit: src/sys/arch/amd64/amd64
Date: Mon, 21 Feb 2011 12:55:09 +0100

 Hi,
 
 the patch will hardcode %al/ax/eax/rax for this kind of instruction.
 The result is that the cmp instruction will print the correct register 
 name now.
 
 As already stated in the PR, I'm not very confirmed with the intel/amd 
 instruction set. So I cannot say if hardcoding to the "lower" set of 
 register names is correct for all affected instructions - see list in 
 orignal PR.
 The fact that either %rax or %r8 was already hardcoded before, the log 
 message for the patch sounds reasonable, as long as there are no 
 instructions that hardcode r8 somewhere and these are mapped to case "A" 
 in the implementation too.
 If this has been validated, I think this PR can be closed.
 
 Best regards
 
 W. Stukenbrock
 
 Matthias Drochner wrote:
 
 > The following reply was made to PR port-amd64/44405; it has been noted by 
 > GNATS.
 > 
 > From: "Matthias Drochner" <drochner%netbsd.org@localhost>
 > To: gnats-bugs%gnats.NetBSD.org@localhost
 > Cc: 
 > Subject: PR/44405 CVS commit: src/sys/arch/amd64/amd64
 > Date: Fri, 18 Feb 2011 18:00:52 +0000
 > 
 >  Module Name:        src
 >  Committed By:       drochner
 >  Date:               Fri Feb 18 18:00:52 UTC 2011
 >  
 >  Modified Files:
 >      src/sys/arch/amd64/amd64: db_disasm.c
 >  
 >  Log Message:
 >  fix misinterpretation of REX prefixes where use of the accumulator
 >  as operand is hardwired into the instruction code,
 >  mostly from Wolfgang Stukenbrock per PR port-amd64/44405
 >  
 >  
 >  To generate a diff of this commit:
 >  cvs rdiff -u -r1.13 -r1.14 src/sys/arch/amd64/amd64/db_disasm.c
 >  
 >  Please note that diffs are not public domain; they are subject to the
 >  copyright notices on the relevant files.
 >  
 > 
 
 
 -- 
 
 
 Dr. Nagler & Company GmbH
 Hauptstraße 9
 92253 Schnaittenbach
 
 Tel. +49 9622/71 97-42
 Fax +49 9622/71 97-50
 
 Wolfgang.Stukenbrock%nagler-company.com@localhost
 http://www.nagler-company.com
 
 
 Hauptsitz: Schnaittenbach
 Handelregister: Amberg HRB
 Gerichtsstand: Amberg
 Steuernummer: 201/118/51825
 USt.-ID-Nummer: DE 273143997
 Geschäftsführer: Dr. Martin Nagler, Dr. Dr. Karl-Kuno Kunze