Re: kern/43200: Remove trailing comma in rump.h.

[christos%zoulas.com@localhost (Christos Zoulas)]

The following reply was made to PR kern/43200; it has been noted by GNATS.

From: christos%zoulas.com@localhost (Christos Zoulas)
To: gnats-bugs%NetBSD.org@localhost, kern-bug-people%netbsd.org@localhost, 
        gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost, 
        henning.petersen%t-online.de@localhost
Cc: 
Subject: Re: kern/43200: Remove trailing comma in rump.h.
Date: Sat, 24 Apr 2010 11:05:20 -0400

 On Apr 24, 12:25pm, pooka%NetBSD.org@localhost (Antti Kantee) wrote:
 -- Subject: Re: kern/43200: Remove trailing comma in rump.h.
 
 |  While I have no strong opinion, we need to remember that rump.h
 |  should be buildable on a non-NetBSD toolchain.  That said, you need
 |  a C99 compiler for the NetBSD kernel, so situations where this has
 |  any practical relevance are likely far and apart.
 
 Yes, but we have tools in userland that should be buildable with non
 c99 compilers, specially the bootstrap ones.
 
 |  And, actually, trailing comma for enums is not preferred style (+).
 |  But I propose we change it -- not getting diffs for the previous
 |  line when appending an enum is useful.
 |  
 |  +)
 |  
 |  /* $NetBSD: style,v 1.46 2010/04/24 00:54:07 christos Exp $ */
 |  [...]
 |  /* Enum types are capitalized.  No comma on the last element. */
 |  enum enumtype {
 |          ONE,
 |          TWO
 |  } et;
 
 As long as you make it clear that for portability tools should not
 have the trailing comma, but the kernel and non-tools userland programs
 should.
 
 christos