NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: kern/43200: Remove trailing comma in rump.h.
The following reply was made to PR kern/43200; it has been noted by GNATS.
From: Antti Kantee <pooka%NetBSD.org@localhost>
To: Martin Husemann <martin%duskware.de@localhost>
Cc: Christos Zoulas <christos%zoulas.com@localhost>,
gnats-bugs%NetBSD.org@localhost,
kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
netbsd-bugs%netbsd.org@localhost, henning.petersen%t-online.de@localhost
Subject: Re: kern/43200: Remove trailing comma in rump.h.
Date: Sat, 24 Apr 2010 15:20:04 +0300
On Sat, Apr 24, 2010 at 05:55:50AM +0200, Martin Husemann wrote:
> On Fri, Apr 23, 2010 at 07:03:18PM -0400, Christos Zoulas wrote:
> > Not in the current version of c++ though I think. Eventually but not now.
>
> They have been always allowed in C++.
> Trailing comma is prefered style, so what is this PR about, after all?
While I have no strong opinion, we need to remember that rump.h
should be buildable on a non-NetBSD toolchain. That said, you need
a C99 compiler for the NetBSD kernel, so situations where this has
any practical relevance are likely far and apart.
And, actually, trailing comma for enums is not preferred style (+).
But I propose we change it -- not getting diffs for the previous
line when appending an enum is useful.
+)
/* $NetBSD: style,v 1.46 2010/04/24 00:54:07 christos Exp $ */
[...]
/* Enum types are capitalized. No comma on the last element. */
enum enumtype {
ONE,
TWO
} et;
Home |
Main Index |
Thread Index |
Old Index