port-macppc/42998: macppc POWERMAC_G5 kernel build fails in powerpc/oea/ofw_consinit.c: failsafe_cons undeclared

[dennis.c.ferguson%gmail.com@localhost]

>Number:         42998
>Category:       port-macppc
>Synopsis:       macppc POWERMAC_G5 kernel build fails in 
>powerpc/oea/ofw_consinit.c: failsafe_cons undeclared
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    port-macppc-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Mar 18 07:45:00 +0000 2010
>Originator:     Dennis Ferguson
>Release:        macppc 5.99.24
>Organization:
>Environment:
Compile machine is:

Darwin dennislaptop 10.2.0 Darwin Kernel Version 10.2.0: Tue Nov  3 10:35:19 
PST 2009; root:xnu-1486.2.11~1/RELEASE_X86_64 x86_64
>Description:
I attempted to do a

    MACHINE=macppc ./build.sh kernel=POWERMAC_G5

and got this result:

    #   compile  POWERMAC_G5/ofw_consinit.o
    ...
    /Users/dennis/NetBSD/5.0-current/src/sys/arch/powerpc/oea/ofw_consinit.c: 
In function 'cninit':
    /Users/dennis/NetBSD/5.0-current/src/sys/arch/powerpc 
/oea/ofw_consinit.c:153: error: 'failsafe_cons' undeclared (first use in this 
function)
    
/Users/dennis/NetBSD/5.0-current/src/sys/arch/powerpc/oea/ofw_consinit.c:153: 
error: (Each undeclared identifier is reported only once
    
/Users/dennis/NetBSD/5.0-current/src/sys/arch/powerpc/oea/ofw_consinit.c:153: 
error: for each function it appears in.)

    *** Failed target:  ofw_consinit.o

The variable 'failsafe_cons' is indeed referenced in
arch/powerpc/oea/ofw_consinit.c in code #ifdef'd by PMAC_G5.
That structure is declared and initialized in
arch/macppc/macppc/failsafe.c, and that file is also compiled
into the kernel, but none of the .h files which ofw_consinit.c
includes (or any .h files in the kernel that I can find,
anywhere) have an extern declaration for it.
>How-To-Repeat:
Try to build a macppc POWERMAC_G5 kernel.  I suspect this
hasn't been done for a while since fixing (i.e. hacking
around) the problem I'm reporting here finds another one
in a source file with a name later in the alphabet.
>Fix: