Re: PR/42828 CVS commit: src/bin/sh

[christos%zoulas.com@localhost (Christos Zoulas)]

The following reply was made to PR standards/42828; it has been noted by GNATS.

From: christos%zoulas.com@localhost (Christos Zoulas)
To: gnats-bugs%NetBSD.org@localhost, standards-manager%netbsd.org@localhost, 
        gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost, 
rhansen%bbn.com@localhost
Cc: 
Subject: Re: PR/42828 CVS commit: src/bin/sh
Date: Wed, 17 Feb 2010 14:25:35 -0500

 On Feb 17,  6:55pm, mm_lists%pulsar-zone.net@localhost (Matthew Mondor) wrote:
 -- Subject: Re: PR/42828 CVS commit: src/bin/sh
 
 | The following reply was made to PR standards/42828; it has been noted by 
GNATS.
 | 
 | From: Matthew Mondor <mm_lists%pulsar-zone.net@localhost>
 | To: gnats-bugs%NetBSD.org@localhost
 | Cc: 
 | Subject: Re: PR/42828 CVS commit: src/bin/sh
 | Date: Wed, 17 Feb 2010 13:51:26 -0500
 | 
 |  On Wed, 17 Feb 2010 16:00:07 +0000 (UTC)
 |  Christos Zoulas <christos%netbsd.org@localhost> wrote:
 |  
 |  >  Modified Files:
 |  >   src/bin/sh: main.c
 |  >  
 |  >  Log Message:
 |  >  PR/42828: Richard Hansen: Don't evaluate ${ENV} if not interactive.
 |  >  
http://www.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_05_03
 |  >  
 |  >  
 |  >  To generate a diff of this commit:
 |  >  cvs rdiff -u -r1.53 -r1.54 src/bin/sh/main.c
 |  
 |  Thanks for the fix;
 |  
 |  would this be worthy of a pullup to netbsd-5*?  I've seen occasional
 |  user complaints about this, although if being careful and adding
 |  interactive-intended code inside "case "$-" in *i*)" this wasn't a
 |  major problem.  But I myself got bitten by this long ago when I
 |  switched from another shell to /bin/sh, yet I didn't know this was a
 |  standards compatibility issue.
 
 Sure thing.
 
 christos