port-sparc/42398: tools/compat fails to cross-compile on darwin

[jeremyhu%freedesktop.org@localhost]

>Number:         42398
>Category:       port-sparc
>Synopsis:       tools/compat fails to cross-compile on darwin
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    port-sparc-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Dec 02 01:50:00 +0000 2009
>Originator:     Jeremy Huddleston
>Release:        Building netbsd-4
>Organization:
NA
>Environment:
Build machine: Darwin nanake.local 10.2.0 Darwin Kernel Version 10.2.0: Tue Nov 
 3 10:37:10 PST 2009; root:xnu-1486.2.11~1/RELEASE_I386 i386

>Description:
obj ===> tools/fgen
echo /Users/jeremy/src/netbsd/netbsd-4/tooldir.nanake >PREVIOUSTOOLDIR
dependall ===> host-mkdep
install ===> host-mkdep
dependall ===> compat
mkdir -p include/sys include/machine include/rpc include/arpa
rm -f config.cache
CC=cc CFLAGS=-O LDFLAGS=  /bin/sh 
/Users/jeremy/src/netbsd/netbsd-4/src/tools/compat/configure 
--cache-file=config.cache
configure: creating cache config.cache
checking for gcc... cc
checking for C compiler default output... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for executable suffix... 
checking for object suffix... o
checking whether we are using the GNU C compiler... yes
checking whether cc accepts -g... yes
checking how to run the C preprocessor... cc -E
checking for NetBSD... no
checking for sh... /bin/sh
checking whether byte ordering is bigendian... no
checking for ANSI C header files... yes
checking for zlib.h... yes
checking for gzdopen in -lz... yes
checking for sys/ioctl.h... yes
checking for sys/mman.h... yes
checking for sys/mtio.h... no
configure: error: standard system header file not found

*** Failed target:  config.cache
*** Failed command: CC=cc CFLAGS=-O LDFLAGS= /bin/sh 
/Users/jeremy/src/netbsd/netbsd-4/src/tools/compat/configure 
--cache-file=config.cache
*** Error code 1

>How-To-Repeat:
cvs checkout -r netbsd-4 src
cvs checkout -r netbsd-4 xsrc

ROOT_DIR="$(pwd)"
BUILD_CMD="./build.sh -X ${ROOT_DIR}/xsrc -T ${ROOT_DIR}/tooldir.nanake -R 
${ROOT_DIR}/releasedir -u"

SPARC_OPTS="-m sparc -D ${ROOT_DIR}/destdir.sparc -O ${ROOT_DIR}/obj.sparc"

${BUILD_CMD} ${SPARC_OPTS} tools || exit $?
${BUILD_CMD} ${SPARC_OPTS} kernel=VINCENT.MP || exit $?
${BUILD_CMD} ${SPARC_OPTS} -U -x build || exit $?
${BUILD_CMD} ${SPARC_OPTS} -U -x release || exit $?
${BUILD_CMD} ${SPARC_OPTS} -U -x iso-image || exit $?

>Fix:
Just remove the check?  I don't see why it's even there:

~/src/netbsd/netbsd-4/src/tools/compat  $ grep -R mtio .
./configure:for ac_header in sys/ioctl.h sys/mman.h sys/mtio.h sys/param.h \
./configure.ac:AC_CHECK_HEADERS(sys/ioctl.h sys/mman.h sys/mtio.h sys/param.h \
./nbtool_config.h.in:/* Define if you have the <sys/mtio.h> header file. */

You also should not fail when you can't find sys/ndir.h, sys/dir.h, or <ndir.h> 
since those are also conditionally included