NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: lib/41223: libcurses: curs_set and move do not cause refresh on getch



The following reply was made to PR lib/41223; it has been noted by GNATS.

From: Brett Lymn <blymn%baesystems.com.au@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: lib-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
netbsd-bugs%netbsd.org@localhost,
        jld%panix.com@localhost
Subject: Re: lib/41223: libcurses: curs_set and move do not cause refresh on 
getch
Date: Tue, 21 Apr 2009 22:12:04 +0930

 On Tue, Apr 21, 2009 at 05:25:02AM +0000, Jed Davis wrote:
 > 
 >  I've prepared a patch to make the change I proposed (of removing the
 >  is_wintouched check), and in minimal testing it appears to work.  See
 >  http://www.NetBSD.org/~jld/nbcurses-getch-refresh.diff , or below:
 >
 
 I do not think this is the correct thing to do.  It is unacceptable to
 force a refresh of the window for every character as this may mean, in
 some very dumb terminal cases, a redraw of the screen.
 
 SUS v2 is not clear on the expected behaviour and I, personally, don't
 hold a certain other curses package as being authorative on curses
 behaviour.
 
 A peek at the Open Solaris curses code shows they perform a fflush on
 the output file descriptor after the tput - I think that would be a
 better solution.
   
 -- 
 Brett Lymn
 "Warning:
 The information contained in this email and any attached files is
 confidential to BAE Systems Australia. If you are not the intended
 recipient, any use, disclosure or copying of this email or any
 attachments is expressly prohibited.  If you have received this email
 in error, please notify us immediately. VIRUS: Every care has been
 taken to ensure this email and its attachments are virus free,
 however, any loss or damage incurred in using this email is not the
 sender's responsibility.  It is your responsibility to ensure virus
 checks are completed before installing any data sent in this email to
 your computer."
 
 


Home | Main Index | Thread Index | Old Index