Re: kern/41158: nfs_rename() locking against myself

[Andrew Doran <ad%netbsd.org@localhost>]

The following reply was made to PR kern/41158; it has been noted by GNATS.

From: Andrew Doran <ad%netbsd.org@localhost>
To: Manuel Bouyer <bouyer%antioche.eu.org@localhost>
Cc: gnats-bugs%NetBSD.org@localhost
Subject: Re: kern/41158: nfs_rename() locking against myself
Date: Wed, 8 Apr 2009 20:34:39 +0000

 On Wed, Apr 08, 2009 at 10:28:50PM +0200, Manuel Bouyer wrote:
 > On Wed, Apr 08, 2009 at 08:05:03PM +0000, Andrew Doran wrote:
 > >  >  This is interesting:
 > >  >  
 > >  >  
 > > http://docs.freebsd.org/cgi/getmsg.cgi?fetch=544278+0+archive/1999/cvs-all/19990627.cvs-all
 > >  
 > >  If we add the 'goto nfsmout' we need the FreeBSD change to nfs_syscalls.c,
 > >  to handle NFSERR_RETVOID.
 > 
 > I see that they're also using nfsm_srvdone in nfsrv_null() and nfsrv_noop()
 > where I've keept the return(0). Is the nfs_syscalls.c change still needed
 > in this case ?
 > AFAIK is only matters for nfsrv_null() ...
 
 On having a second look I guess it does not matter.
 A mistake in their change?