Re: kern/41158: nfs_rename() locking against myself

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

The following reply was made to PR kern/41158; it has been noted by GNATS.

From: Manuel Bouyer <bouyer%antioche.eu.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: kern-bug-people%NetBSD.org@localhost, gnats-admin%NetBSD.org@localhost, 
netbsd-bugs%NetBSD.org@localhost
Subject: Re: kern/41158: nfs_rename() locking against myself
Date: Wed, 8 Apr 2009 22:28:50 +0200

 On Wed, Apr 08, 2009 at 08:05:03PM +0000, Andrew Doran wrote:
 >  >  This is interesting:
 >  >  
 >  >  
 > http://docs.freebsd.org/cgi/getmsg.cgi?fetch=544278+0+archive/1999/cvs-all/19990627.cvs-all
 >  
 >  If we add the 'goto nfsmout' we need the FreeBSD change to nfs_syscalls.c,
 >  to handle NFSERR_RETVOID.
 
 I see that they're also using nfsm_srvdone in nfsrv_null() and nfsrv_noop()
 where I've keept the return(0). Is the nfs_syscalls.c change still needed
 in this case ?
 AFAIK is only matters for nfsrv_null() ...
 
 > I'm looking at the rest of the changes but won't
 >  have time to go through them all tonight.
 
 thanks
 
 -- 
 Manuel Bouyer <bouyer%antioche.eu.org@localhost>
      NetBSD: 26 ans d'experience feront toujours la difference
 --