re: kern/40431 (recent fxp change broke my fxp)

[matthew green <mrg%eterna.com.au@localhost>]

The following reply was made to PR kern/40431; it has been noted by GNATS.

From: matthew green <mrg%eterna.com.au@localhost>
To: yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi)
Cc: netbsd-bugs%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
    gnats-bugs%NetBSD.org@localhost
Subject: re: kern/40431 (recent fxp change broke my fxp)
Date: Sat, 21 Feb 2009 04:24:16 +1100

    > Synopsis: recent fxp change broke my fxp
    > 
    > State-Changed-From-To: open->feedback
    > State-Changed-By: mrg%NetBSD.org@localhost
    > State-Changed-When: Fri, 20 Feb 2009 06:23:14 +0000
    > State-Changed-Why:
    > please test with the latest changes to fpx/i8255x driver. thanks.
    
    KASSERT at i82557.c:378 failed during boot.
 
 please try the following patch.  thanks.
 
 
 .mrg.
 
 
 Index: pci/if_fxp_pci.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/pci/if_fxp_pci.c,v
 retrieving revision 1.62
 diff -p -r1.62 if_fxp_pci.c
 *** pci/if_fxp_pci.c   20 Feb 2009 05:49:34 -0000      1.62
 --- pci/if_fxp_pci.c   20 Feb 2009 17:23:31 -0000
 *************** fxp_pci_attach(device_t parent, device_t
 *** 382,388 ****
                aprint_normal(": %s, rev %d\n", fpp->fpp_name, sc->sc_rev);
                if (sc->sc_rev >= FXP_REV_82558_A4)
                        sc->sc_flags |= FXPF_FC|FXPF_EXT_TXCB;
 !              if (sc->sc_rev == FXP_REV_82550 || sc->sc_rev == 
FXP_REV_82550_C)
                        sc->sc_flags |= FXPF_EXT_RFA;
   
                break;
 --- 382,388 ----
                aprint_normal(": %s, rev %d\n", fpp->fpp_name, sc->sc_rev);
                if (sc->sc_rev >= FXP_REV_82558_A4)
                        sc->sc_flags |= FXPF_FC|FXPF_EXT_TXCB;
 !              if (sc->sc_rev >= FXP_REV_82550)
                        sc->sc_flags |= FXPF_EXT_RFA;
   
                break;