Re: re: port-i386/40677: Some fxp network cards no longer work

["Stephan Thesing" <thesing%gmx.de@localhost>]

The following reply was made to PR port-i386/40677; it has been noted by GNATS.

From: "Stephan Thesing" <thesing%gmx.de@localhost>
To: gnats-bugs%NetBSD.org@localhost, netbsd-bugs%netbsd.org@localhost, 
gnats-admin%netbsd.org@localhost,
 port-i386-maintainer%netbsd.org@localhost
Cc: 
Subject: Re: re: port-i386/40677: Some fxp network cards no longer work
Date: Tue, 17 Feb 2009 22:23:04 +0100

 I think the general idea of moving feature determination to the
 frontend file is good.
 
 It should be sufficient to change in fxp_pci_attach() in if_fxp_pci.c
 the default: branch of the switch, along the lines of the attached patch
 (compile tested only).
 
 Index: if_fxp_pci.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/pci/if_fxp_pci.c,v
 retrieving revision 1.61
 diff -b -u -r1.61 if_fxp_pci.c
 --- if_fxp_pci.c        18 Jan 2009 10:37:04 -0000      1.61
 +++ if_fxp_pci.c        17 Feb 2009 21:22:09 -0000
 @@ -373,16 +373,29 @@
         case PCI_PRODUCT_INTEL_82562EH_HPNA_2:
         case PCI_PRODUCT_INTEL_PRO_100_VM_2:
                 aprint_normal(": %s, rev %d\n", fpp->fpp_name, sc->sc_rev);
 +
 +               if (sc->sc_rev >= FXP_REV_82558_A4)
                 sc->sc_flags |= FXPF_FC|FXPF_EXT_TXCB;
 +
 +               if (sc->sc_rev == FXP_REV_82550 || sc->sc_rev == 
FXP_REV_82550_C)
 +                       sc->sc_flags |= FXPF_EXT_RFA|FXPF_IPCB;
                 /*
                  * The ICH-2 and ICH-3 have the "resume bug".
                  */
                 sc->sc_flags |= FXPF_HAS_RESUME_BUG;
                 break;
 
 +
         default:
                 aprint_normal(": %s, rev %d\n", fpp->fpp_name, sc->sc_rev);
 -               sc->sc_flags |= FXPF_FC|FXPF_EXT_TXCB|FXPF_EXT_RFA|FXPF_IPCB;
 +
 +
 +               if (sc->sc_rev >= FXP_REV_82558_A4)
 +                       sc->sc_flags |= FXPF_FC|FXPF_EXT_TXCB;
 +
 +if (sc->sc_rev == FXP_REV_82550 || sc->sc_rev == FXP_REV_82550_C)
 +                       sc->sc_flags |= FXPF_EXT_RFA|FXPF_IPCB;
 +
                 break;
         }
 
 
 
 -------- Original-Nachricht --------
 > Datum: Tue, 17 Feb 2009 21:05:03 +0000 (UTC)
 > Von: matthew green <mrg%eterna.com.au@localhost>
 > An: port-i386-maintainer%netbsd.org@localhost, 
 > gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost, 
 > thesing%gmx.de@localhost
 > Betreff: re: port-i386/40677: Some fxp network cards no longer work
 
 > The following reply was made to PR port-i386/40677; it has been noted by
 > GNATS.
 > 
 > From: matthew green <mrg%eterna.com.au@localhost>
 > To: gnats-bugs%NetBSD.org@localhost
 > Cc: port-i386-maintainer%netbsd.org@localhost, 
 > gnats-admin%netbsd.org@localhost,
 >     netbsd-bugs%netbsd.org@localhost
 > Subject: re: port-i386/40677: Some fxp network cards no longer work
 > Date: Wed, 18 Feb 2009 08:01:46 +1100
 > 
 >  i will back out the fxp changes.
 >  
 >  
 >  .mrg.
 >  
 
 -- 
 Dr.-Ing. Stephan Thesing
 Elektrastr. 50
 81925 München
 GERMANY
 
 Jetzt 1 Monat kostenlos! GMX FreeDSL - Telefonanschluss + DSL 
 für nur 17,95 Euro/mtl.!* http://dsl.gmx.de/?ac=OM.AD.PD003K11308T4569a