NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
port-i386/40608: a small mistake in a comment in sys/arch/i386/stand/lib/dump_eax.S
>Number: 40608
>Category: port-i386
>Synopsis: a small mistake in a comment in
>sys/arch/i386/stand/lib/dump_eax.S
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: port-i386-maintainer
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Wed Feb 11 07:00:00 +0000 2009
>Originator: Gao Ya'nan
>Release: NetBSD-current and NetBSD-4.0
>Organization:
>Environment:
NetBSD abutter.foo.org 4.0 NetBSD 4.0 (GENERIC) #0: Sun Dec 16 00:20:10 PST
2007
builds@wb34:/home/builds/ab/netbsd-4-0-RELEASE/i386/200712160005Z-obj/home/builds/ab/netbsd-4-0-RELEASE/src/sys/arch/i386/compile/GENERIC
i386
>Description:
----------------------------------->cut<-------------------------------
#if 1 /* 5 bytes to generate real hex... */
daa /* 30..39, 40..45 */
addb $0xc0, %al /* f0..f9, 00..05 */
adcb $0x40, %al /* 30..39, 41..45 */
#endif
----------------------------------->cut<-------------------------------
so, after adcb operation, AL will fall in betwwen 0x30 to 0x39 or between 0x41
to 0x46 but 0x45.
A small mistake.
>How-To-Repeat:
Read the code
>Fix:
Change
adcb $0x40, %al /* 30..39, 41..45 */
to
adcb $0x40, %al /* 30..39, 41..46 */
Home |
Main Index |
Thread Index |
Old Index