Re: kern/40586: rgephy(4) now selects incorrect speed for some re(4)

[Geoff Wing <gcw%pobox.com@localhost>]

The following reply was made to PR kern/40586; it has been noted by GNATS.

From: Geoff Wing <gcw%pobox.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/40586: rgephy(4) now selects incorrect speed for some
        re(4)
Date: Tue, 10 Feb 2009 10:45:46 +1100

 On Monday 2009-02-09 23:40 +0000, Christoph Egger output:
 : rgephy_load_dspcode() already does this revision check.
 : You can safely call it unconditionally.
 
 I guess my patch doesn't clearly indicate the revival of all the
 code that is now "#if 0"d out, some being initial different
 PHY_WRITE() values and then the following PHY_WRITE()s in:
 
         /* Reset capabilities */
         /* Step1: write our capability */
         /* 10/100 capability */
         /* 1000 capability */
         /* Step2: Restart NWay */
         /* NWay enable and Restart NWay */
 
 which isn't handled by rgephy_load_dspcode().
 
 Regards,
 Geoff