Re: netbsd-3 branch won't build; minor fix

[Alan Barrett <apb%cequrux.com@localhost>]

On Fri, 23 Jan 2009, Brad Parker wrote:
> >> I was trying to build netbsd-3 and netbsd-3-3-1-RELEASE and ran
> >> into a small problem.  This was cross compiling for vax on using a
> >> linux host.

Please report this using send-pr.

> one of the libraries (lib/libmagic) would not build because MIN() was
> defined twice.  I included a diff which show (I thought) the problem.
> 
> It occurred because the local include defined MIN() and then included a
> system include which also defined it (always best to put system includes 
> first, imho)

Your diff showed what you thought the fix should be, but didn't say what
the problem was.  Do you know which system header defined MIN?

> ps: there is another problem; WARNS?=4 in a makefile causes (usr.bin/xargs)
> 
>   .if ${WARNS} > 3
>   CFLAGS+=        -std=c99
>   .endif

In NetBSD-current, the repevant line of src/share/mk/bsd.sys.mk has:

.if ${WARNS} > 3 && defined(HAVE_GCC) && ${HAVE_GCC} >= 3

Does making this change work for you?  Either way, please report the
problem via send-pr.

--apb (Alan Barrett)