Re: kern/38456

[Wolfgang Solfrank <Wolfgang%Solfrank.net@localhost>]

The following reply was made to PR kern/38456; it has been noted by GNATS.

From: Wolfgang Solfrank <Wolfgang%Solfrank.net@localhost>
To: Darren Reed <darrenr%NetBSD.org@localhost>
Cc: ws%tools.de@localhost, gnats-bugs%NetBSD.org@localhost
Subject: Re: kern/38456
Date: Tue, 02 Dec 2008 01:19:49 +0100

 This is a multi-part message in MIME format.
 --------------010405000900090409060302
 Content-Type: text/plain; charset=UTF-8; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Hello,
 
 I'm mostly happy with your changes.  However, I think there are some glitches:
 
 1. ip_compat.h: There is a #ifdef _KERNEL in line 797 and another one in
 line 800.  The latter is unnecessary clutter.
 
 2. ip_fil_netbsd.c: There are missing SPL_X(s) calls in ipfattach (if
 pfil_head_get fails) and ipfdetach (if pfil_remove_hook fails).
 
 3 ip_sync.c: The macro WAKEUP takes two arguments.
 
 Find a patch below.
 
 Ciao,
 Wolfgang
 -- 
 Wolfgang%Solfrank.net@localhost                                Wolfgang 
Solfrank
 
 --------------010405000900090409060302
 Content-Type: text/plain;
  name="patch"
 Content-Transfer-Encoding: base64
 Content-Disposition: inline;
  filename="patch"
 
 SW5kZXg6IGlwX2NvbXBhdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnNyb290L3Ny
 Yy9zeXMvZGlzdC9pcGYvbmV0aW5ldC9pcF9jb21wYXQuaCx2CnJldHJpZXZpbmcgcmV2aXNp
 b24gMS4yMwpkaWZmIC11IC1yMS4yMyBpcF9jb21wYXQuaAotLS0gaXBfY29tcGF0LmgJNiBO
 b3YgMjAwOCAwOTo1MTo1NyAtMDAwMAkxLjIzCisrKyBpcF9jb21wYXQuaAkyIERlYyAyMDA4
 IDAwOjE3OjQ3IC0wMDAwCkBAIC03OTcsNyArNzk3LDYgQEAKICMgaWZkZWYgX0tFUk5FTAog
 IyBpZiAoX19OZXRCU0RfVmVyc2lvbl9fID49IDQ5OTAwMDAwMCkKIHR5cGVkZWYJY2hhciAq
 CWNhZGRyX3Q7Ci0jICBpZmRlZiBfS0VSTkVMCiAjICAgaW5jbHVkZSA8c3lzL3J3bG9jay5o
 PgogIyAgIGRlZmluZQlVU0VfTVVURVhFUwkJMQogIyAgIGRlZmluZQlLTVVURVhfVAkJa211
 dGV4X3QKQEAgLTgxOCw3ICs4MTcsNiBAQAogIyAgIGRlZmluZQlTUExfTkVUKHgpCQk7CiAj
 ICAgZGVmaW5lCVNQTF9JTVAoeCkJCTsKICMgICBkZWZpbmUJU1BMX1goeCkJCTsKLSMgIGVu
 ZGlmCiAjIGVuZGlmCiAjICBpZiAoX19OZXRCU0RfVmVyc2lvbl9fID49IDM5OTAwMTQwMCkK
 ICMgICBkZWZpbmUJS01BTExPQ1MoYSwgYiwgYykJKGEpID0gKGIpbWFsbG9jKChjKSwgX01f
 SVBGLCBNX05PV0FJVCkKSW5kZXg6IGlwX2ZpbF9uZXRic2QuYwo9PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJD
 UyBmaWxlOiAvY3Zzcm9vdC9zcmMvc3lzL2Rpc3QvaXBmL25ldGluZXQvaXBfZmlsX25ldGJz
 ZC5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjQ3CmRpZmYgLXUgLXIxLjQ3IGlwX2ZpbF9u
 ZXRic2QuYwotLS0gaXBfZmlsX25ldGJzZC5jCTYgTm92IDIwMDggMDk6NDk6NTkgLTAwMDAJ
 MS40NworKysgaXBfZmlsX25ldGJzZC5jCTIgRGVjIDIwMDggMDA6MTc6NDggLTAwMDAKQEAg
 LTM3Niw2ICszNzYsNyBAQAogIyAgIGVuZGlmCiAJICAgKSB7CiAJCXByaW50ZigicGZpbF9o
 ZWFkX2dldCBmYWlsZWRcbiIpOworCQlTUExfWChzKTsKIAkJcmV0dXJuIEVOT0RFVjsKIAl9
 CiAKQEAgLTUyMCw4ICs1MjEsMTAgQEAKIAllcnJvciA9IHBmaWxfcmVtb3ZlX2hvb2soKHZv
 aWQgKilmcl9jaGVjaywgUEZJTF9JTnxQRklMX09VVCwKIAkJCQkgJmluZXRzd1tpcF9wcm90
 b3hbSVBQUk9UT19JUF1dLnByX3BmaCk7CiAjICBlbmRpZgotCWlmIChlcnJvcikKKwlpZiAo
 ZXJyb3IpIHsKKwkJU1BMX1gocyk7CiAJCXJldHVybiBlcnJvcjsKKwl9CiAjIGVsc2UKIAlw
 ZmlsX3JlbW92ZV9ob29rKCh2b2lkICopZnJfY2hlY2ssIFBGSUxfSU58UEZJTF9PVVQpOwog
 IyBlbmRpZgpAQCAtNTM2LDggKzUzOSwxMCBAQAogCWVycm9yID0gcGZpbF9yZW1vdmVfaG9v
 aygodm9pZCAqKWZyX2NoZWNrLCBQRklMX0lOfFBGSUxfT1VULAogCQkJCSAmaW5ldHN3W2lw
 X3Byb3RveFtJUFBST1RPX0lQVjZdXS5wcl9wZmgpOwogIyAgZW5kaWYKLQlpZiAoZXJyb3Ip
 CisJaWYgKGVycm9yKSB7CisJCVNQTF9YKHMpOwogCQlyZXR1cm4gZXJyb3I7CisJfQogIyBl
 bmRpZgogI2VuZGlmCiAJZnJfZGVpbml0aWFsaXNlKCk7CkluZGV4OiBpcF9zeW5jLmMKPT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PQpSQ1MgZmlsZTogL2N2c3Jvb3Qvc3JjL3N5cy9kaXN0L2lwZi9uZXRpbmV0
 L2lwX3N5bmMuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xMQpkaWZmIC11IC1yMS4xMSBp
 cF9zeW5jLmMKLS0tIGlwX3N5bmMuYwk0IE5vdiAyMDA4IDIxOjQxOjExIC0wMDAwCTEuMTEK
 KysrIGlwX3N5bmMuYwkyIERlYyAyMDA4IDAwOjE3OjQ4IC0wMDAwCkBAIC05MjAsNyArOTIw
 LDcgQEAKICMgZWxzZQogCU1VVEVYX0VYSVQoJmlwc2xfbXV0ZXgpOwogIyAgaWZkZWYgX0tF
 Uk5FTAotCVdBS0VVUCgmc2xfdGFpbCk7CisJV0FLRVVQKCZzbF90YWlsLCAwKTsKIAlQT0xM
 V0FLRVVQKElQTF9MT0dTWU5DKTsKICMgIGVuZGlmCiAjIGVuZGlmCkBAIC0xMDEwLDcgKzEw
 MTAsNyBAQAogIyBlbHNlCiAJTVVURVhfRVhJVCgmaXBzbF9tdXRleCk7CiAjICBpZmRlZiBf
 S0VSTkVMCi0JV0FLRVVQKCZzbF90YWlsKTsKKwlXQUtFVVAoJnNsX3RhaWwsIDApOwogCVBP
 TExXQUtFVVAoSVBMX0xPR1NZTkMpOwogIyAgZW5kaWYKICMgZW5kaWYK
 --------------010405000900090409060302--