kern/39974: modules/ffs: can't mount log filesystems if vfs_wapbl.c not built in kernel

[xtraeme%gmail.com@localhost]

>Number:         39974
>Category:       kern
>Synopsis:       modules/ffs: can't mount log filesystems if vfs_wapbl.c not 
>built in kernel
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Nov 20 11:00:00 +0000 2008
>Originator:     Juan RP
>Release:        Latest
>Organization:
>Environment:
NetBSD vmware-netbsd 5.99.3 NetBSD 5.99.3 (MASTER) #10: Thu Nov 20 11:40:06 CET 
2008  juan@vmware-netbsd:/home/juan/build/obj/sys/arch/i386/compile/MASTER i386
>Description:
If a kernel is built without WAPBL (no options WAPBL) and the x86
bootloader autoloads the ffs module, it won't be able to mount a fs
with log option. That's because vfs_wapbl.c is not built in the
ffs module or in another dependent module.



>How-To-Repeat:

>Fix:
There are two ways to fix this:

1) Build the ffs module with vfs_wapbl.c.
2) Build another wapbl module and make ffs depend on it.

As quick fix I used the first option:

Index: Makefile
===================================================================
RCS file: /cvsroot/src/sys/modules/ffs/Makefile,v
retrieving revision 1.2
diff -b -u -p -r1.2 Makefile
--- Makefile    13 Nov 2008 10:50:26 -0000      1.2
+++ Makefile    20 Nov 2008 10:50:41 -0000
@@ -16,4 +16,7 @@ SRCS+=        ffs_alloc.c ffs_balloc.c ffs_inod
        ffs_vfsops.c ffs_vnops.c ffs_softdep.stub.c ffs_snapshot.c \
        ffs_bswap.c ffs_wapbl.c ffs_appleufs.c
 
+.PATH: ${S}/kern
+SRCS+= vfs_wapbl.c
+
 .include <bsd.kmodule.mk>