re: kern/39514: ataraid(4): basic bio(4) support

[matthew green <mrg%eterna.com.au@localhost>]

The following reply was made to PR kern/39514; it has been noted by GNATS.

From: matthew green <mrg%eterna.com.au@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
    netbsd-bugs%netbsd.org@localhost, xtraeme%gmail.com@localhost
Subject: re: kern/39514: ataraid(4): basic bio(4) support 
Date: Fri, 12 Sep 2008 10:13:53 +1000

      
     +  char    aai_name[32];           /* array volume name */
 
     [ ... ]
 
     +  if (aai->aai_name)
     +          strlcpy(bv->bv_vendor, aai->aai_name,
     +              sizeof(bv->bv_vendor));
 
 
 this will always be true.
 
 it seems that you should make aai_name a char * instead
 of an array, and to malloc/free the space for it as
 necessary.  limiting names to 31 chars is going to bite
 someone in the future.
 
 
 
 .mrg.