NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: kern/39514: ataraid(4): basic bio(4) support



     
    +   char    aai_name[32];           /* array volume name */

    [ ... ]

    +   if (aai->aai_name)
    +           strlcpy(bv->bv_vendor, aai->aai_name,
    +               sizeof(bv->bv_vendor));


this will always be true.

it seems that you should make aai_name a char * instead
of an array, and to malloc/free the space for it as
necessary.  limiting names to 31 chars is going to bite
someone in the future.



.mrg.


Home | Main Index | Thread Index | Old Index