Re: lib/39215: getdevmajor()/major() types don't match

[christos%zoulas.com@localhost (Christos Zoulas)]

The following reply was made to PR lib/39215; it has been noted by GNATS.

From: christos%zoulas.com@localhost (Christos Zoulas)
To: M.Drochner%fz-juelich.de@localhost
Cc: gnats-bugs%NetBSD.org@localhost, lib-bug-people%NetBSD.org@localhost, 
        gnats-admin%NetBSD.org@localhost, netbsd-bugs%NetBSD.org@localhost, 
        dholland%eecs.harvard.edu@localhost
Subject: Re: lib/39215: getdevmajor()/major() types don't match
Date: Thu, 7 Aug 2008 02:49:31 -0400

 On Aug 6,  9:49pm, M.Drochner%fz-juelich.de@localhost (Matthias Drochner) 
wrote:
 -- Subject: Re: lib/39215: getdevmajor()/major() types don't match
 
 | christos%zoulas.com@localhost said:
 | > I think PRI macros should be used otherwise if you use casts, this
 | > will silence the truncation to int for long for example. 
 | 
 | OK, I've introduced PRIdevmajor... I've left the casts for now
 | where special formatting is done, where the minor number is
 | interpreted as device unit (which is "int" throughout autoconf -
 | I'd say a devunit_t would go a bit too far), or where I'm not
 | sure about portability (some userland tools).
 | I din't like the PRI stuff too much because it looks ugly,
 | but if it the only clean way...
 | 
 | (ignore the udf patch)
 | 
 | best regards
 | Matthias
 
 Looks better. You fixed some printfs but not all of them, why?
 
 christos