Re: port-powerpc/39257: Mistake in sys/arch/powerpc/powerpc/trap_subr.S file

[Konrad Karpowicz <konradk%pacomp.pl@localhost>]

The following reply was made to PR port-powerpc/39257; it has been noted by 
GNATS.

From: Konrad Karpowicz <konradk%pacomp.pl@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: port-powerpc-maintainer%netbsd.org@localhost, 
gnats-admin%netbsd.org@localhost, 
 netbsd-bugs%netbsd.org@localhost, konstrukcja <konstrukcja%pacomp.pl@localhost>
Subject: Re: port-powerpc/39257: Mistake in sys/arch/powerpc/powerpc/trap_subr.S
 file
Date: Fri, 01 Aug 2008 11:43:03 +0200

 Tim Rightnour pisze:
 >  I looked at the file at the location you mentioned, but I don't think the
 >  current code in CVS matches whatever you are looking at.  The line numbers 
 > you
 >  gave don't match up.  Can you please either tell me what the CVS revision
 >  number at the top of the file you are looking at is, or look at the most
 >  current one, which is
 Dear Tim,
 Thank you very much for quick answer. You are right, I was looking at 
 trap_subr.S v1.59.
 In v 1.64 the line numbers are 540-547.
 Lines 540 and 541: in my opinion the contents of R1 are not used anymore.
 Line 544: change of the contents of R2 results in incorrect value loaded 
 into R1 in line 547.
 Kind regards,
 Konrad
 
 
 
 Tim Rightnour pisze:
 > The following reply was made to PR port-powerpc/39257; it has been noted by 
 > GNATS.
 >
 > From: Tim Rightnour <root%garbled.net@localhost>
 > To: konradk%pacomp.pl@localhost
 > Cc: gnats-bugs%netbsd.org@localhost
 > Subject: RE: port-powerpc/39257: Mistake in 
 > sys/arch/powerpc/powerpc/trap_subr.S file
 > Date: Thu, 31 Jul 2008 11:55:01 -0700 (MST)
 >
 >  On 31-Jul-2008 konradk%pacomp.pl@localhost wrote:
 >  > Our company uses FreeBSD on PowerPC e300 core and I wanted to compare our 
 > TLB
 >  > Data Store Miss Exception handler with the same part of code in NetBSD. 
 > In my
 >  > opinion there is a serious bug in sys/powerpc/powerpc/trap_subr.S file -
 >  > lines
 >  > 617-624. Value stored in R1 is not used. And changed value in R2 causes 
 > error
 >  > when reloading TLB entry. It would be great if I could contact someone 
 > who is
 >  > able to confirm (or not) my opinion.
 >  > Kind regards,
 >  > Konrad
 >  
 >  I looked at the file at the location you mentioned, but I don't think the
 >  current code in CVS matches whatever you are looking at.  The line numbers 
 > you
 >  gave don't match up.  Can you please either tell me what the CVS revision
 >  number at the top of the file you are looking at is, or look at the most
 >  current one, which is:
 >  
 >  /*      $NetBSD: trap_subr.S,v 1.64 2008/05/24 21:39:01 phx Exp $       */
 >  
 >  Then let me know which line numbers in that file.
 >  
 >  ---
 >  Tim Rightnour <root%garbled.net@localhost>
 >  NetBSD: Free multi-architecture OS http://www.netbsd.org/
 >  Genecys: Open Source 3D MMORPG: http://www.genecys.org/
 >  
 >
 >