Re: kern/38763

[Havard Eidnes <he%NetBSD.org@localhost>]

The following reply was made to PR kern/38763; it has been noted by GNATS.

From: Havard Eidnes <he%NetBSD.org@localhost>
To: ad%NetBSD.org@localhost
Cc: gnats-bugs%NetBSD.org@localhost
Subject: Re: kern/38763
Date: Mon, 26 May 2008 23:42:04 +0200 (CEST)

 > Module Name: src
 > Committed By:        ad
 > Date:                Sun May 25 19:22:21 UTC 2008
 >
 > Modified Files:
 >      src/sys/arch/amiga/dev: mfc.c msc.c
 >      src/sys/arch/sparc64/dev: sab.c
 >      src/sys/dev/dec: dz.c
 >      src/sys/dev/ic: cy.c
 >      src/sys/dev/ir: irframe_tty.c
 >      src/sys/dev/qbus: dhu.c
 >      src/sys/dev/sbus: spif.c
 >      src/sys/kern: tty.c tty_pty.c tty_subr.c
 >      src/sys/net: ppp_tty.c
 >      src/sys/sys: tty.h
 >
 > Log Message:
 > Properly fix the "hanging in tty" bug that was worked around with cv_wakeup()
 > some time again.
 
 This also removed clwakeup() from the interface, but it was left used
 by some of the TTY drivers, as per PR#38763.  Is this diff correct?
 
 Index: dec/dz.c
 ===================================================================
 RCS file: /u/nb/src/sys/dev/dec/dz.c,v
 retrieving revision 1.36
 diff -u -p -r1.36 dz.c
 --- dec/dz.c   25 May 2008 19:22:21 -0000      1.36
 +++ dec/dz.c   26 May 2008 21:32:15 -0000
 @@ -271,7 +271,7 @@ dzrint(void *arg)
                cn_check_magic(tp->t_dev, mcc, dz_cnm_state);
  
                if (!(tp->t_state & TS_ISOPEN)) {
 -                      clwakeup(&tp->t_rawq);
 +                      cv_broadcast(&tp->t_rawcv);
                        continue;
                }
  
 Index: qbus/dhu.c
 ===================================================================
 RCS file: /u/nb/src/sys/dev/qbus/dhu.c,v
 retrieving revision 1.53
 diff -u -p -r1.53 dhu.c
 --- qbus/dhu.c 25 May 2008 19:22:21 -0000      1.53
 +++ qbus/dhu.c 26 May 2008 21:34:11 -0000
 @@ -362,7 +362,7 @@ dhurint(void *arg)
                }
  
                if (!(tp->t_state & TS_ISOPEN)) {
 -                      clwakeup(&tp->t_rawq);
 +                      cv_broadcast(&tp->t_rawcv);
                        continue;
                }
  
 Index: qbus/dl.c
 ===================================================================
 RCS file: /u/nb/src/sys/dev/qbus/dl.c,v
 retrieving revision 1.41
 diff -u -p -r1.41 dl.c
 --- qbus/dl.c  28 Apr 2008 20:23:56 -0000      1.41
 +++ qbus/dl.c  26 May 2008 21:34:59 -0000
 @@ -276,7 +276,7 @@ dlrint(void *arg)
                cc = c & 0xFF;
  
                if (!(tp->t_state & TS_ISOPEN)) {
 -                      clwakeup(&tp->t_rawq);
 +                      cv_broadcast(&tp->t_rawcv);
                        return;
                }